Don't require a deep fetch for forks about create-pull-request

[peter-evans]

@infinisil Just saw your comment here: #2849 (comment)

This fix did actually address your original issue, but now the problem has shifted to the later fetch of the pull request branch. I can't hardcode that to depth=1, because there will be cases where some users have multiple commits on the branch.

I have an idea to fix it. I'll experiment with it next week.

[peter-evans]

Released as v6.0.4 / v6.

[infinisil]

Ah good point, I now updated the fork to PR against and reran the action, looks like that also works: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8707862728/job/23892105339

[willbush]

I was just searching through this repo briefly and I wonder if this comment is related?

[peter-evans]

Hi @infinisil

could a GitHub server update make this be possible suddenly?

I think you might be right. It seems to be working now without doing the fetch with --unshallow! 😮

Thank you for pointing it out! I'll release a fix for this.

[peter-evans]

Released as v6.0.3 / v6.

Thank you!

[peter-evans]

@infinisil, would you be willing to test a new version of the action before I release it? It's not easy for me to test this with a real-world case like yours. I've made a change to limit the fetch depth when fetching the pull request branch.

You can try the new version like this:

uses: peter-evans/create-pull-request@branch-fetch-depth

[infinisil]

Sure! Just did, and it seems to work: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8707862728/job/23883876037 ✨ (tweag/nixpkgs#91, this is a PR from a fork to another fork, but I don't think that would influence the result)

[peter-evans]

Sure! Just did, and it seems to work: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8707862728/job/23883876037 ✨ (tweag/nixpkgs#91, this is a PR from a fork to another fork, but I don't think that would influence the result)

Thanks for testing, but this isn't doing the same as your original run here: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8633608062/job/23667098826

The PR branch needs to exist before the action runs. Otherwise the fetch just fails and it creates a new branch. The perf problem comes when the branch exists and the fetch pulls all the history for the PR branch. So please keep fork/test-some-change existing on the fork repo and run it again so the fetch occurs.

[peter-evans]

Ah good point, I now updated the fork to PR against and reran the action, looks like that also works: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8707862728/job/23892105339

Looks good! Down to 15 seconds from 10 minutes. Thank you for testing it.

I'm slightly nervous about releasing this because there is a possibility that someone is using the action in a way that I've not anticipated and this update clobbers their workflow. So just be aware that I might need to roll this back if it causes some issue for a lot of users. I think it will be a rare edge case if it causes any problem at all.

[infinisil]

So just be aware that I might need to roll this back if it causes some issue for a lot of users. I think it will be a rare edge case if it causes any problem at all.

Sounds good, no worries, thanks a lot for the quick fix!