peter-tackage / kotlin-options Goto Github PK

Write a README for each module with a description and usage

The distribution of the artifacts generated from the modules needs to be modified so that each module can be independent included by using a separate artifactId. After this Investigation should include how to upload bintray rather than jitpack.

How about showing in README first how kotlin would do it's null mapping, something like this:

getCurrentUserId()
    ?.takeIf { it.isNotEmpty() && it != "Invalid Id" }
    ?.let { getCurrentUserFromDatabase(it) }
    ?.username
    ?.let { "Logged in user: $it" }
    .apply {
        if (this != null) {
            log(this)
        } else {
            log("No user to login!")
        }
    }

Of course we would need to mentione that those versions of getCurrentUserId and getCurrentUserFromDatabase return kotlin's nullable

In kotlin method for filtering out nulls from a list is called filterNotNull.
Would it make sense to add filterNotNone and deprecate the filterIfSome?

Currently the constructor for Some is marked internal. I am now thinking that there's no benefit to not exposing it and preventing direct instantiation as:

1. We already expose the Some and None classes, so these types are known by library clients.
2. By ensuring the Some constructor only takes <T : Any> we prevent incorrect creation or require checkNotNull like in Java - there's no run time risk.
3. For readability purposes, it would make defining a specific Option value clearer when using non-nulls than requiring use of optionOf. It could just be Some("abc").

Thoughts? @tomaszpolanski

Write API docs

Hi,

hope find you well with this cold call.

I am an author of mocking framework for Kotlin

I see you are using mockito-kotlin.

I just want you to be aware that there is solution that fully supports Kotlin and ask to try it in your new/current projects.

I can help you if you answer to this issue.

Thanks and please star it