GithubHelp home page GithubHelp logo

Documentation for `VariantArray` and `VariantNames` say their `VARIANTS` constants are arrays, but they're actually slices about strum HOT 2 CLOSED

IndigoLily avatar IndigoLily commented on June 12, 2024
Documentation for `VariantArray` and `VariantNames` say their `VARIANTS` constants are arrays, but they're actually slices

from strum.

Comments (2)

T0mstone avatar T0mstone commented on June 12, 2024 2

Wow, I was about to write the same issue. What a coincidence!

You're right, making them true arrays won't work yet, since associated types aren't allowed to depend on associated constants. A workaround would be to make the array length a generic parameter of the trait, but that's pretty unwieldy, in addition to being semantically completely wrong.

I would be in favor of the macros also generating an inherent associated constant which is a true array. That way we can at least use the constant length in non-generic code.

from strum.

Peternator7 avatar Peternator7 commented on June 12, 2024 1

There was discussion when the features were added about slices vs arrays. Like @T0mstone said, associated constants still aren't great to use. It also makes adding a new variant to an enum a breaking change because the length of the array changes, but slices don't have that issue.

from strum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.