GithubHelp home page GithubHelp logo

Comments (15)

pedrohenriquebr avatar pedrohenriquebr commented on May 31, 2024 2

Hi, look at the docker branch. I'm using the Makefile for automating tasks.

docker.

maybe this can help...

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024 2

I have to learn Travis CI a bit more myself but I've done some work with it already. You're welcomed to have a look at my fork to see what @pedrohenriquebr has done so far I started my stuff in my own fork but Pedro's fork has a lot more features than I would've imagined to do. I also requested that he document how someone would use it.

@pedrohenriquebr if you could use https://asciinema.org to record a quick "video" of how your Dockerfile docker-compose and Makefile's work it would be very interesting to see.

from ownhealthrecord.

pedrohenriquebr avatar pedrohenriquebr commented on May 31, 2024 2

Here https://asciinema.org/a/222853

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024 2

@pedrohenriquebr I love the makefile its very nice! The only critique I would make is that when it comes down to Documentation we should favour using Docker commands because that makes the instructions more portable across operating systems. Otherwise good job looks great to me!

from ownhealthrecord.

petrk94 avatar petrk94 commented on May 31, 2024 1

Hi guys,

really nice what you are doing here about docker^^
I even would like to make a docker version, but it doesnt help, if there are more docker versions which might be not working properly or make problems etc.

I want to make a official docker compose file, if you modify something on it, please mention it on the readme file, otherwise it can be harmful.
Share here your ideas what you want to make for a docker stuff.

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024 1

One of the things that could be beneficial for a container that builds all branches via something like Travis CI would be you could build an entire test suite to ensure that your product is always effective.

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024 1

@pedrohenriquebr how should we go about using this Dockerfile and commit history you've added? I would love to start with yours and then perhaps do a PR together.

I didn't see your PR on my fork I'll do a bit of work on it if @petrk94 is okay with the idea however it sounds like they want to do it all themselves.

What would recommend is that if @petrk94 wants to only have official releases be pushed to Docker Hub that they only build a specific branch and consider that branch only there for pushing docker releases. A production branch would be ideal but there's heaps of ways to do it.

from ownhealthrecord.

petrk94 avatar petrk94 commented on May 31, 2024 1

@Leopere
Yes, please send me your docker file/ docker-compose and we can check it here together whether it's fine or what can be improved.

The reason why I want a official docker release on docker hub is, that I have seen already other projects where was different releases there and that's just a mess to find the one which is still maintained or at least working.

This Travis CI I never have made, so I have to get into it

from ownhealthrecord.

petrk94 avatar petrk94 commented on May 31, 2024 1

@pedrohenriquebr if its related to the issue, please share it here too. Thanks

@Leopere if you have already a docker file we can test, just send me a PR I will test it and than we can merge

from ownhealthrecord.

petrk94 avatar petrk94 commented on May 31, 2024 1

@Leopere
I have checked that out, but all of them looks more complicated.
Rather I think medoo is much more easier and provide the same functions we need to make the application usable for more than just one database model.

https://medoo.in / https://github.com/catfan/Medoo

from ownhealthrecord.

pedrohenriquebr avatar pedrohenriquebr commented on May 31, 2024

@Leopere I sent a message to you on Gitter

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024

So from your video @pedrohenriquebr I'm noticing one big glaring issue, I think that generally people these days prefer to have the database schema automatically created if its not there. @petrk94 would you be opposed to writing something that would do this automatically when OHR is initialized?

from ownhealthrecord.

pedrohenriquebr avatar pedrohenriquebr commented on May 31, 2024

@Leopere Okay, I'm going to modify the Makefile

from ownhealthrecord.

petrk94 avatar petrk94 commented on May 31, 2024

@Leopere
I had planned to use a php database framework so it will take over this work. But due there is encryption code inside, I have to test it when I have time.
So as next what is necessary, is to create the necessary tables for the database over the setup form at the beginning.

from ownhealthrecord.

Leopere avatar Leopere commented on May 31, 2024

@petrk94 https://www.slant.co/topics/5639/~php-orms might put you on the right path.

from ownhealthrecord.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.