Comments (7)
Hi @shamil--thanks for the report. Have you tried escaping the hash in the password value with a backslash, or quoting the entire value?
from collector.
I ran into this too - see #132. I fixed it by replacing the hash. Hashes should be allowed in passwords without having to escape them IMO. Or if that doesn't work for some reason it would be nice if pganalyze raised a error telling you to fix the password. Currently it dies to a seg violation.
from collector.
@caleb15 oh wow, it definitely shouldn't segfault. I only suggested quoting or escaping because a hash is a .ini
comment character, so I assumed the hash and everything after were being ignored, leading to a different password. Are you setting the password via db_password
or db_url
?
from collector.
So I tried this myself with db_url and I was able to reproduce the crash. The hash character is treated as a comment by https://github.com/go-ini/ini, which we use for parsing the config file, and the resulting invalid URL fails to parse, and we're not doing proper error-checking regarding valid URLs. Unfortunately, it looks like the quoting and escaping suggestions I made earlier do not solve this--looks like go-ini does not handle this correctly: go-ini/ini#277 go-ini/ini#187 .
from collector.
We have a fix in progress for the error handling in #133 to avoid the crash and allow #
in values, but the root cause here is that the character is reserved in URLs (since it delineates the start of the fragment), so it must be URL-encoded as %23
. Could you please try that @caleb15 @shamil? That should work even in current collector versions.
from collector.
Closing since #133 should fix this; please reopen if there are still issues.
from collector.
I'm using db_url. I fixed it by removing the hash.
from collector.
Related Issues (20)
- Error calling pg_stat_statements_reset() as requested intermittently HOT 2
- Regular collector oom-kill at midnight UTC on Sundays HOT 1
- Publish Docker image to ECR public registry HOT 1
- Error to send snapshots HOT 2
- Upgrade go.uuid module HOT 3
- Missing image for v0.50.1 HOT 2
- Additional security settings for pganalyze collector HOT 3
- Add rudimentary test suite for Helm chart
- Debian build uses EOL version HOT 1
- Error: Failed to reload collector HOT 1
- OTEL connector - can it support Datadog APM traces for PostgreSQL HOT 2
- OTEL connector - can it support Datadog?
- Feature request: Add DB_PASSWORD_FILE or similar HOT 1
- Regarding SSO login HOT 1
- Configuring Log Insights for pganalyze runnning on kubernetes pod HOT 1
- Can't ctrl-c pganalyze-collector HOT 1
- panic: runtime error: index out of range [0] with length 0 HOT 5
- Inefficient usage of AWS DescribeDBInstances and DescribeDBClusters API HOT 1
- OTEL Collector: allow plain json payloads HOT 3
- Panic when processing server HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from collector.