Can't use the collector when there is a hash (#) in the password about collector

[msakrejda]

Hi @shamil--thanks for the report. Have you tried escaping the hash in the password value with a backslash, or quoting the entire value?

[caleb15]

I ran into this too - see #132. I fixed it by replacing the hash. Hashes should be allowed in passwords without having to escape them IMO. Or if that doesn't work for some reason it would be nice if pganalyze raised a error telling you to fix the password. Currently it dies to a seg violation.

[msakrejda]

@caleb15 oh wow, it definitely shouldn't segfault. I only suggested quoting or escaping because a hash is a .ini comment character, so I assumed the hash and everything after were being ignored, leading to a different password. Are you setting the password via db_password or db_url?

[msakrejda]

So I tried this myself with db_url and I was able to reproduce the crash. The hash character is treated as a comment by https://github.com/go-ini/ini, which we use for parsing the config file, and the resulting invalid URL fails to parse, and we're not doing proper error-checking regarding valid URLs. Unfortunately, it looks like the quoting and escaping suggestions I made earlier do not solve this--looks like go-ini does not handle this correctly: go-ini/ini#277 go-ini/ini#187 .

[msakrejda]

We have a fix in progress for the error handling in #133 to avoid the crash and allow # in values, but the root cause here is that the character is reserved in URLs (since it delineates the start of the fragment), so it must be URL-encoded as %23. Could you please try that @caleb15 @shamil? That should work even in current collector versions.

[msakrejda]

Closing since #133 should fix this; please reopen if there are still issues.

[caleb15]

I'm using db_url. I fixed it by removing the hash.