Comments (6)
I think you might be right with the last point. Extensions which I have added prior to yesterday's web store update are no longer updating. This will probably require some work inspecting the XHR requests now used (if any).
It seems Comments are no longer valid as they are now considered Reviews and users can only submit one (or so it seems).
Also, as of Chrome 15 the Extensions link should probably be changed to the new URL: chrome://settings/extensionSettings (found in Chrome's Options). The original URL (chrome://extensions) still works but it's probably best to just update this.
from myextensions.
I did some debugging and found that the problems adding and updating extensions are linked and seem to stem from the same line of code;
js.js:1417
var matches = responseText.match(/<img class="detail-logo-[^"]*" src="([^"]*)" alt="Logo">[\s\S]*<div class="detail-title">([^<]*)<\/div>([^<]*)<[\s\S]*<div class="detail-num-users">([^<]*) users<[\s\S]*Version: <\/b>([^<]*)<[\s\S]*<span id='detail-update-date'>([^<]*)<[\s\S]*users<br>([^<]*) weekly installs</i);
The RegExp no longer matches anything in responseText
really as the DOM structure and ordering has changed along with class names when the web store was updated.
from myextensions.
I had some time and wanted to play around with regex so I think this is a good fix;
var matches = responseText.match(/<img class="detail-dialog-icon[^"]*" alt="Extension" src="([^"]*)"[^>]*>[^<]*<[\s\S]*<h1 class="detail-dialog-title">([^<]*)<\/h1>[^<]*<[\s\S]*(?:<span class="detail-dialog-from[^"]*"[^>]*>(?:[^<]*<a[^>]*>([^<]*)<\/a>|from(?: )*([^<]*))<\/span>|<div class="detail-dialog-from[^"]*"[^>]*>Verified author: ([^<]*)<\/div>)[^<]*<[\s\S]*<span class="detail-dialog-users"[^>]*>([^<]*) users<\/span>[^<]*<[\s\S]*<div class="overview-tab-right-bar-summary"[^>]*>([^<]*)<\/div>/i);
You may have noticed that weekly installs and version are no longer matched. Unfortunately, I see no way of getting the version as it is on the Details tab which is not rendered in the response. However, the concept of weekly installs appears to have been dropped entirely (which I'm really happy about).
The matches
variable now has the following important elements;
- Image
- Title
- Author (from link)
- Author (from plain text)
- Author (Verified author: domain)
- Users
- Summary description (although not currently used I thought I'd match it while I was doing this - feel free to remove)
My regex skills aren't great and you may be able to merge Author in to a single match; otherwise a simple OR would suffice. Obviously this is only some the work required and js.js will need updated to reference the correct indices. Also, any reference to the version and/or weekly installs will need to be removed unless an alternative method of determining either can be found.
from myextensions.
I've opened a pull request for this which includes a quick fix for this problem. However, I suggest that the code relating to version and weekly installs information are cleaned afterwards.
from myextensions.
@mkzero It appears the extension on Chrome Web Store has already been updated with the fix I provided. Can you confirm that you no longer see this problem so this issue can be closed off?
from myextensions.
Okay, works just fine now, closing this.
from myextensions.
Related Issues (20)
- Updates broken, again HOT 2
- Average rating diff dissappearing HOT 1
- Chrome Update HOT 3
- Network error, cannot retrieve content HOT 7
- Corrupted installation? HOT 5
- Cannot reload stats anymore HOT 1
- Google Sync support HOT 11
- Empty popup HOT 6
- paid apps, unable to view crx
- Is this project open source? HOT 4
- User rating comments no longer showing up HOT 3
- Can you add `Support` row? HOT 3
- Google Sheets add-on store support HOT 2
- Doesn't work, at all? HOT 16
- Extension doesn't work in my spanish chrome HOT 2
- Firefox support ?
- Some problem accessing to webstore HOT 1
- is this project still maintained? HOT 1
- rating counts do not include post-webstore-upgrade ratings HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from myextensions.