GithubHelp home page GithubHelp logo

Comments (4)

bencoman avatar bencoman commented on July 26, 2024

Perhaps a QA rule would also help - if it could quick detect method name is "isAbstract" before it is saved?

from calypso.

jecisc avatar jecisc commented on July 26, 2024

QA rule can be added to help fix a potential error in a #isAbstract method, but it cannot help with my initial problem for two reasons:

  • First, QA is launched after the saving of the method, so Calypso will already be crashed
  • Second, it's probably not recommended but maybe one day someone will want to implement #isAbstract method for their model, not using it in its original intended way. I don't think Calypso should crash if it happens.

So, IMO the minimal fix for it is to catch a potential error and consider the class as non-abstract in that case. Adding a QA rule might be good as a next step.

from calypso.

dionisiydk avatar dionisiydk commented on July 26, 2024

I think it needs to be protected in more general way (not just isAbstract case).
Any table decoration can be broken or half implemented. And browser should not crash because of that

from calypso.

dionisiydk avatar dionisiydk commented on July 26, 2024

From the other side isAbstract is used in many different features (not only to show italic class names).
So users need to be protected

from calypso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.