Comments (4)
Perhaps a QA rule would also help - if it could quick detect method name is "isAbstract" before it is saved?
from calypso.
QA rule can be added to help fix a potential error in a #isAbstract method, but it cannot help with my initial problem for two reasons:
- First, QA is launched after the saving of the method, so Calypso will already be crashed
- Second, it's probably not recommended but maybe one day someone will want to implement #isAbstract method for their model, not using it in its original intended way. I don't think Calypso should crash if it happens.
So, IMO the minimal fix for it is to catch a potential error and consider the class as non-abstract in that case. Adding a QA rule might be good as a next step.
from calypso.
I think it needs to be protected in more general way (not just isAbstract case).
Any table decoration can be broken or half implemented. And browser should not crash because of that
from calypso.
From the other side isAbstract is used in many different features (not only to show italic class names).
So users need to be protected
from calypso.
Related Issues (20)
- Tables should be well refreshed when adding a method HOT 4
- New method tab disappear HOT 3
- Specifying a menu command like: $f meta shift (doesn't show shift icon in menu) HOT 1
- There is no keyboard shortcut for Format Code in the method pane
- Scroll special event on the source code
- Calypso should use not deprecated methods in Pharo 8 HOT 1
- Add CI for Pharo 8
- Far too many branches HOT 11
- Add "Make abstract" command HOT 1
- Add new API to browse classes using query browser
- DNU when try to file out category (WriteStream(Object)>>doesNotUnderstand: #trailer)
- #createRefactoring:for: should be moved up to Slot HOT 2
- Package Filter not restored switching from Scoped to AllPackages HOT 1
- Running Critic with a Manifest containing an obsolete class ref gives walkback
- Show protocol of methods in message browser HOT 3
- Set filter when opening Calypso from other point than world
- Plugin for SUnit test method pane integration with template auto-generation
- In Pharo11, browsing version history raises mnu's on RGBehavior #syntaxHighlighter, #isDeprecated, #isAbstract
- categorizing a selection of multiple methods does not work. instead only one gets categorized.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calypso.