Comments (4)
Yes, many users of IceTipStandardAction
have this problem. Chasing it down for a bit, it seems many of them have been migrated to a new pattern where the calling IceTipCommand
asks for a #newWhateverAction
then sends it executeWithContext:
, rather than calling a method which makes and immediately evaluates the IceTipStandardAction
. See for instance IceTipDeleteBranchCommand>>execute
, making use of IceTipBranchModel>>newDeleteAction
.
I believe I've managed to chase down all the remaining cases—PR incoming.
from iceberg.
I was thinking to first add
application
^ StPharoApplication current
in the superclass of action.
Then later we can pass an application.
from iceberg.
I thought of something like that, but by the time I determined what the right default value for application
would even be (StPharoApplication current
sounds right, yes), I had discovered that the vast majority of commands were already using the #newXAction
+ #executeWithContext:
pattern. And all the cases I found were easily migrated to that pattern, so no need for a hard-coded default.
from iceberg.
Ah then even better. Now since we want to remove the dependencies to UIManager the "UI" should be passed via the Application. This way we will one single point of control.
from iceberg.
Related Issues (20)
- Lint issues in #validate should be solved by proper categorization
- Instabilitity probably due to inform:during: HOT 1
- Expanding tag list gets IceTipTagModel DNU #branchName
- missing newInform HOT 1
- DNU when repair: Discard Image changes and load repository version HOT 2
- Create tag does not look to create a tag HOT 5
- Regression: Default format of a repo should not be filetree HOT 1
- Red screen of death while attaching repository HOT 2
- Erros in auth dialog when using https HOT 1
- [Feature Request] Select from available projects repos for a GitHub/GitLab user
- create a tag does not create a tag. HOT 2
- Mergelist should show the tags in addition to the branches
- Error on browse method versions HOT 2
- Push does not push tags other than in head commit HOT 1
- Pharo stop responding when pushing without internet connection
- Branch status confusing
- Wrong comment in IceTipEntityModel class>>#new
- The first time we add a package and commit in a project the package is not added to the project
- If the command git is unvailable, username/password dialog throws an exception
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iceberg.