GithubHelp home page GithubHelp logo

Comments (4)

daniels220 avatar daniels220 commented on July 26, 2024

Yes, many users of IceTipStandardAction have this problem. Chasing it down for a bit, it seems many of them have been migrated to a new pattern where the calling IceTipCommand asks for a #newWhateverAction then sends it executeWithContext:, rather than calling a method which makes and immediately evaluates the IceTipStandardAction. See for instance IceTipDeleteBranchCommand>>execute, making use of IceTipBranchModel>>newDeleteAction.

I believe I've managed to chase down all the remaining cases—PR incoming.

from iceberg.

Ducasse avatar Ducasse commented on July 26, 2024

I was thinking to first add

application 
  ^ StPharoApplication current 

in the superclass of action.
Then later we can pass an application.

from iceberg.

daniels220 avatar daniels220 commented on July 26, 2024

I thought of something like that, but by the time I determined what the right default value for application would even be (StPharoApplication current sounds right, yes), I had discovered that the vast majority of commands were already using the #newXAction + #executeWithContext: pattern. And all the cases I found were easily migrated to that pattern, so no need for a hard-coded default.

from iceberg.

Ducasse avatar Ducasse commented on July 26, 2024

Ah then even better. Now since we want to remove the dependencies to UIManager the "UI" should be passed via the Application. This way we will one single point of control.

from iceberg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.