GithubHelp home page GithubHelp logo

Comments (5)

philburk avatar philburk commented on August 26, 2024

This looks like a bug.
I added a print at the end of the run() method in StreamingThread.
If I sleepUntil(4.107) then the thread does not finish.
If I sleepUntil(4.108) then the thread finishes.

I found a TODO in AudioFifo.java:
// TODO Maybe we should tell any thread that is waiting that the FIFO is closed.
The StreamingThread was hanging in the read().

So I modified the close() method and it now completes the thread.

from jsyn.

philburk avatar philburk commented on August 26, 2024

@zstojanovic - There is a possible fix in #106.

Please let me know if that works for you.

from jsyn.

zstojanovic avatar zstojanovic commented on August 26, 2024

@philburk - Thanks for such a swift response.

The fix works for me!

I have left one PR comment for your consideration.

from jsyn.

philburk avatar philburk commented on August 26, 2024

@zstojanovic -Thanks for testing the fix.

I have left one PR comment for your consideration.

I don't see any comments in #106. Did you post it?

from jsyn.

zstojanovic avatar zstojanovic commented on August 26, 2024

Did you post it?

Oh, looks like I did not, try now.

from jsyn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.