Comments (3)
Thx for sharing the feedback. We run in ephemeral mode, which ensures instances are only used onces. And new instances are started with the new AMI. In case you run non ephemeral the scale-down should stop old instances, however this only work once they are idle at the moment the lambda is checking.
Please feel free to suggest improvements.
from terraform-aws-github-runner.
Hello 👋
We are ending up in the same situation. It would be super cool if the scale-up/scale-down/pool functions would be able to check if the AMI in use by the active runners is the same as the one defined in the Launch Template. In case it's not, to gracefully terminate the runners not using latest AMI and spin up new ones.
Does it make sense?
from terraform-aws-github-runner.
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.
from terraform-aws-github-runner.
Related Issues (20)
- Lambda ami housekeeper and the ssm parameter store HOT 4
- Default example fails HOT 2
- When to increase size of the pool HOT 3
- Using upstream module from terraform registry is not user friendly HOT 3
- Question: For different AWS profiles and vpc's do I need separate Github apps? HOT 4
- Pool is creating multiple instances while the first is still registering HOT 2
- Runner Lables no longer honored after 5.2.1->5.8.0 upgrade HOT 9
- Error: ssmHousekeeper handler not found HOT 2
- Scale down lambda terminates active runners HOT 2
- Permission Issue When Running multi-runner solution: Access denied for ssm:GetParameter action HOT 3
- Runner i-xxxx is not idle in GitHub and NOT counted as part of the pool HOT 3
- SSM parameters can exceed 4K limit breaking terraform apply HOT 4
- Add support for multiple type of platforms HOT 1
- Docker containers no longer inherit credentials from EC2 instance HOT 1
- Add the ability to use custom labels only HOT 2
- AMI Parameter cannot be a cross account parameter HOT 1
- speedup instance creation for bursty workflows HOT 2
- CodeStar Connections Being replaced by CodeConnections in April 2025 HOT 1
- optional FIFO queue on workflow job events queue HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terraform-aws-github-runner.