Comments (3)
from minphp.
Thanks @Feathur. Unfortunately I won't be able to use the contribution for a few reasons:
- Namespace integration has already begun on the 1.0 branch (see 33aaa39).
- For 1.0 the framework is being decomposed into independent libraries, and bridged over for backwards compatibility with version 0.x.
- One issue you may wish to correct in your commit, is the use of multiple root namespaces. For example, you put
Model
inLib\Model
. A better choice might beMinphp\Lib\Model
(essentially everything in minphp should live behindMinphp\
). As I said the framework is being decomposed, soModel
will end up inMinphp\Mvc\Model
-- part of a totally independent library.
from minphp.
That's perfectly fine. My partner asked that we make the offer, but we had no expectation that you'd want to use it.
from minphp.
Related Issues (20)
- Increase code coverage of Input component
- Increase code coverage of Record component
- Increase code coverage of ACL component
- Increase code coverage of Session component
- Increase code coverage of Core
- Add composer support
- Turn Helpers into individual libs
- Turn Components into individual libs
- Add docs to readthedocs.org HOT 6
- Add coveralls
- Style with bootstrap
- eroor message are showing HTML tags HOT 1
- Record::buildFields() returns prematurely
- Increase requirement to PHP 5.4 HOT 2
- .gitattributes
- Remove jenkins build artifacts
- vendor\autoload.php not exist HOT 9
- Twig framework for templates HOT 2
- how to use the new minphp 1.0.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minphp.