GithubHelp home page GithubHelp logo

Comments (2)

RobDickinson avatar RobDickinson commented on September 4, 2024 1

@jzonthemtn having revisted this with latest code I think this is just an artifact of how this benchmark works.

If you process very small strings (<32 bytes), hundreds of thousands of times per second, and do nothing else, then the overhead for getFiltersForPolicy can look significant like I showed originally. (and that's what I was doing at the time, microbenchmarking with mostly small strings)

Now that we have some real and non-microbenchmarky integrations, I did some analysis on a few more realistic workloads, and I didn't see one where getFiltersForPolicy was significant.

I think I was up pretty late and mis-interpreted this as an opportunity to optimize, cause who wouldn't want ~20%? 😀

I humbly withdraw my complaint

from phileas.

jzonthemtn avatar jzonthemtn commented on September 4, 2024

Sounds good! Appreciate the update.

from phileas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.