GithubHelp home page GithubHelp logo

Comments (11)

phoet avatar phoet commented on June 1, 2024

@jlecour fair enough! the implicit assumption is the .travis.yml file though 😸

what version of ruby are you running on? i don't want to support anything < 1.9 though...

from partially_useful.

phoet avatar phoet commented on June 1, 2024

@jlecour pastis-rb LOL 👍 http://pastisrb.org/

from partially_useful.

phoet avatar phoet commented on June 1, 2024

so, this is now compatible to MRI

  • 2.0.0
  • 2.1.0
  • 2.1.1

from partially_useful.

jlecour avatar jlecour commented on June 1, 2024

I hope you won't mind me nitpicking.

As a user of your gem, I understand the CI test matrix show what version of Ruby you're testing it against. It usually means that you make it work on this versions and don't guarantee that it will pass on others.

Here we have a clear incompatibility.

I'd suggest adding spec.required_ruby_version = '>= 2.0.0' in the gemspec which is a good way tell rubygems that your gem is compatible with Ruby 2+

from partially_useful.

phoet avatar phoet commented on June 1, 2024

@jlecour AFAIK jruby does not work with prepend so this might be a misleading information

from partially_useful.

celsodantas avatar celsodantas commented on June 1, 2024

but isn't adding a required_ruby_version = '>= 2.0.0' better then having Ruby Dependency >= 0?

screen shot 2014-05-15 at 9 56 55 pm

from partially_useful.

phoet avatar phoet commented on June 1, 2024

i've actually never seen this on rubygems. most gems don't have that information displayed, weird...

from partially_useful.

jlecour avatar jlecour commented on June 1, 2024

Maybe the gemspec should also include a platform specification, but I don't know how to exclude JRuby without excluding other implementations that support Module#prepend.

@headius or @brixen might know about this, being involved in non-MRI Ruby implementations.

from partially_useful.

phoet avatar phoet commented on June 1, 2024

@jlecour FYI jruby and 1.9.3 supported now

from partially_useful.

phoet avatar phoet commented on June 1, 2024

[note to self] never use this gem feature ever again, it's stupid and should be removed

from partially_useful.

jlecour avatar jlecour commented on June 1, 2024

@phoet What feature are you talking about?

from partially_useful.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.