Comments (12)
@cedricbonhomme do you mind submitting a PR for the persona/browserid removal?
It should be noted that the proper way to do it would be to have it as a fallback to force setting the password (my instance only uses browserid) if it doesn't exists. When Mozilla finally sunset the server it can be permanently stripped.
I'll start with what you have done. Thanks !
from frontend.
I just deployed a new instance on my computer. Self-login is already the default when going to /setup for the first time.
It seems that I can simply remove the support of persona as I did on my instance.
from frontend.
Hey @hfiguiere how would one go about disabling persona in the app and enabling alternative logins?
from frontend.
more a question for @jmathai .
from frontend.
@Dannyzen Persona is one of the options but it can be disabled via a configuration setting. Are you looking to remove it entirely wherever possible? I can remove it...
from frontend.
@jmathai thanks for responding. I am looking for the definition of which configuration will disable it.
from frontend.
@Dannyzen looks like I was incorrect. Logging in via a locally hosted database is optional (see here) but persona is on by default and cannot be removed (see here).
from frontend.
Hello,
For your information I've made some minor modification on my instance (https://photos.cedricbonhomme.org).
And in fact, I almost never used the BrowserId authentication method. I'm trying to remove it:
https://github.com/cedricbonhomme/frontend/commits/cedric
If this can help.
No problem on my instance, but I need to test with a new setup.
from frontend.
Yes, I can submit a PR. No problem. So you're thinking about having BrowserId as fallback? I think it is the case by default. I changed that: https://github.com/cedricbonhomme/frontend/commit/9e0811ba59a6ce0c7077011112834ae8c452b156#diff-cd7673220e591377b45ebab84ba79766L218
In fact on my branch, there are some personal adaptations for my instance. I have totally removed the support of browserID and Facebook login. I also have removed the link to the apple store.
from frontend.
Initially I was also using BrowserId to log myself as admin. When a decided to switch to the local authentication method I had to edit the database manually. It was one year ago, I don't really remember... I think that I had to change the the column "owner" of the photos.
from frontend.
@cedricbonhomme did you end up putting in a pr?
from frontend.
No, not yet. As I explained on my instance I removed browserID and Facebook login methods.
But I can without problem send a pull request with only the removal of browserID.
I'll do that.
from frontend.
Related Issues (20)
- Discuss future plans for Trovebox HOT 43
- can I edit tag or albums after photo uploaded? HOT 1
- setup-hangs-fails-at-final-step-3 HOT 13
- is trovebox really private if use S3 storage? HOT 1
- can't login in safari browser HOT 2
- Missing Photos in default Album Listing, even after successful upload PLUS duplication of some other photos HOT 4
- S3 bucket eu-central-1 (Frankfurt) not working because of Sigv4 HOT 3
- Error 51 when accessing S3 buckets with a period (.) in the name
- trovebox uploads fail with " Integrity constraint violation:" HOT 6
- Upload photos to Trovebox by dragging them into a folder on Dropbox
- Define a new governance for the project HOT 2
- Project dead? HOT 4
- a
- Call to setActiveFieldForAlbumsFromElement with incorrect number of Parameters ... HOT 2
- installation script does not install prerequisites, and doesn't fail when it can't HOT 4
- Several critical security vulnerabilities - looking for a contact HOT 14
- Frontend capstone project
- Issue Template HOT 3
- [DOCS]: Pull Request template
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend.