deleteAllTags (or write equivalent) throws an exception with "No success message: 0 image files updated", even though image is updated. about exiftool-vendored.js

[mceachen]

Howdy! ExifTool is burping out a warning for that example image you provided:

$ exiftool -all=  -overwrite_original test/delete-test.jpg 
Warning: ICC_Profile deleted. Image colors may be affected - test/delete-test.jpg
    1 image files updated

The error we're looking at is due to this library trying to be "helpful": taskRetries defaults to 1, and we retry write operations. The first time it fails due to the ICC_Profile deletion, and the second time it fails because the second write is a no-op.

So! What to do?

1. Add "ignorable" errors to the config. It's what PhotoStructure has already, I can just move the code here.

2. Only retry read ops. Retrying reads is always safe. Writes, not so much.

3. All of the above

[mceachen]

I've done 2., which means we see a nice error message:

  1) ExifTool
       exiftool({ ignoreShebang: false })
         deleteAllTags
           issue #119:
     Error: Warning: ICC_Profile deleted. Image colors may be affected - /tmp/f5b3de32/test/delete-test.jpg
      at WriteTask.parser (src/ExifToolTask.ts:16:15)
      at WriteTask._Task_resolve (node_modules/batch-cluster/src/Task.ts:144:38)

[mceachen]

Fixed in 160e2fc

[rolanday]

Thanks, Matt! Super helpful & responsive, and appreciate the change to provide a hook for caller to weigh in on if the error is worthy of an exception or not. Works great. My bad for not mentioning the ICC profile error -- I also saw the same but figured unrelated so not worth mentioning. Again, thank you!!

[mceachen]

ICYMI, I released with this fix, too. Thanks for making an easy-to-follow bug report!

Cheers. 🍻

[rolanday]

Saw that earlier and already pulled it. Thanks again! 🥇