GithubHelp home page GithubHelp logo

Comments (7)

php-coder avatar php-coder commented on July 22, 2024

I've just broke it during refactoring for #440 and didn't notice that because our tests don't cover this case.

from mystamps.

mukeshk avatar mukeshk commented on July 22, 2024

Do we consider "seriesowner" login for this test?
Series owner has "series/1" - on collection/seriesowner page.
Should we use this as a test data? - like we remove it?

@general - Our test cases should restore the state of the system back to its original state?
Like we remove it and then should we restore it back?

from mystamps.

php-coder avatar php-coder commented on July 22, 2024

@mukeshk Thank you for the questions!

Yes, we should use "seriesowner" in this test.

The tests don't need to restore the state but we should keep in mind that if more than one tests share the same data, we shouldn't modify this data to keep other tests working. So, that's why in this case, I suggest to update the migration and add yet another series to "seriesowner" collection. That new series we can safely remove from his collection then.

from mystamps.

mukeshk avatar mukeshk commented on July 22, 2024

Sure. I understand will work accordingly.

from mystamps.

mukeshk avatar mukeshk commented on July 22, 2024

When I create a record in series,
Do I need to create records in
Ref: test-series-with-catalogs-numbers.sql

michel_catalog
series_michel_catalog

scott_catalog
series_scott_catalog

yvert_catalog
series_yvert_catalog

gibbons_catalog
series_gibbons_catalog

from mystamps.

php-coder avatar php-coder commented on July 22, 2024

No, just a series is enough. Additional meta information isn't needed as it isn't required by a test case.

from mystamps.

mukeshk avatar mukeshk commented on July 22, 2024

sure. I am almost done with it. I just inserted in the series table before your reply.

from mystamps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.