Bug about phpmetrics

[Halleck45]

Thank's for the report.

PhpMetrics is not yet optimized. The Asymptotic complexity of PhpMetrics is today O = n ^ n . I will optimise it to have O = n log n in the v0.0.6 release

Awaiting the fix, can you give me context of the bug:

• version of PHP
• way to reproduce problme: analyzed sources (version of Dolibarr ?)

Thank's

[deleris]

Bonjour,

je suppose que vous êtes francophone avec votre nom et cela facilitera
notre communication.

Version php 5.3.3
Version dolibarr 3.4.0

Cordialement

On Mon, Mar 24, 2014 at 11:29 PM, Jean-François Lépine <
[email protected]> wrote:

Thank's for the report.

PhpMetrics is not yet optimized. The Asymptotic complexity of
PhpMetrics is today O = n ^ n . I will optimise it to have O = n log n in
the v0.0.6 release

Awaiting the fix, can you give me context of the bug:

• version of PHP
• way to reproduce problme: analyzed sources (version of Dolibarr ?)

Thank's

Reply to this email directly or view it on GitHubhttps://github.com//issues/13#issuecomment-38509595
.

[Halleck45]

Effectivement, mais je vais tenter de répondre en anglais pour les éventuels futurs intéressés, même si mon anglais est mauvais :)

The bug is explained in this composer issue.

Dolibarr contains huge PHP files (more than 1 Mo for tcpdf.php !).

Ways to temporary bypass the problem:

• temporary remove the tcpdf.phpfile
• run php -dmemory_limit=512M metrics.php ...

Ways to fix the problem definitively:

• easy, but uncomfortable for the user:
  • add an --exclude option
• easy and dubious:
  • never analyze large files, and notice user of skipped files
• hard and dubious, but really comfortable:
  • automatically split huge files, get tokens of each files, combine them, then run analyze

[Halleck45]

I've fixed it with the third option

Can you test now please ?