A 64-char hex string should be allowed for the blowfish_secret config directive about phpmyadmin

[M393]

32 characters are 32 bytes! Why do you think it is 16 bytes?

In the documentation the function sodium_hex2bin is used which converts the 64 hex characters to 32 bytes. But you aren't using it in your config, so there it is 64 bytes.

[MauricioFauth]

I think accepting a 64-char hex string and then phpMyAdmin converts it to binary internally is reasonable.
What do you think @williamdes?

[williamdes]

I think accepting a 64-char hex string and then phpMyAdmin converts it to binary internally is reasonable. What do you think @williamdes?

I agree, let's be more flexible

[StefanRacoveanu]

I see that the check that produced the error is here:

phpmyadmin/src/Controllers/HomeController.php

Line 328 in b2c9cbc

} elseif ($encryptionKeyLength > SODIUM_CRYPTO_SECRETBOX_KEYBYTES) {

The above check is called by the __invoke() function in the HomeController:

phpmyadmin/src/Controllers/HomeController.php

Line 216 in b2c9cbc

$this->checkRequirements();

I believe that the best course of action is to add a check if the string is 64 characters long after which check if the string is hexadecimal using the ctype_xdigit() function. If this check is also true, then use the hex2bin() function to convert the string and override the original blowfish_secret. If any of the checks fail the blowfish_secret should remain unchanged.

Also, the documentation should be changed to reflect the change in behaviour. Should I change that in the same PR?

@MauricioFauth What do you think?