GithubHelp home page GithubHelp logo

Comments (5)

PowerKiKi avatar PowerKiKi commented on August 17, 2024 2

This issue is specifically for already deprecated things that need to be dropped before the first release. We are beyond the deprecating phase (by several years in some cases). While I agree with you for future deprecations, I don't think it applies here.

from phpspreadsheet.

PowerKiKi avatar PowerKiKi commented on August 17, 2024 1

Following the lack of input from @MarkBaker I took the iniative to un-deprecate those last few methods.

from phpspreadsheet.

Quix0r avatar Quix0r commented on August 17, 2024

This might be a clear way of deprecation:

  1. mark the method or code block as @deprecated and document a replacement
  2. after x time-unit (e.g. 1/2 year?) remove the deprecated code

from phpspreadsheet.

PowerKiKi avatar PowerKiKi commented on August 17, 2024

@MarkBaker I worked on removing deprecated methods and documenting their replacements.

But I got stuck on getCalculatedValue(), setFormulaAttributes() and setFormulaAttributes(), because I couldn't find any replacement. They've been deprecated in 59932b0 and the changelog mention that replacements will be added in the future, but it seems that it's never been done. It seems that everything is related to PHPOffice/PHPExcel#9. Is it still something that you are working on ? What should we do about getCalculatedValue() ?

from phpspreadsheet.

Quix0r avatar Quix0r commented on August 17, 2024

getCalculatedValue() seems to be intensively used by PHPSpreadsheet: https://github.com/PHPOffice/PhpSpreadsheet/search?q=getCalculatedValue&type=Code&utf8=%E2%9C%93

from phpspreadsheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.