Comments (2)
I've created pull request for this issue.
Not sure if I've done that properly. According to the documentation:
If you are going to be submitting a pull request, please fork from develop, and submit your pull request back as a fix/feature branch referencing the GitHub issue number
So, I have to create the issue, create branch named as Issue (issue ID?) and then create pull request? Right?
from phpspreadsheet.
What you did was fine. You don't necessarily need to create an issue, but you have to create a branch, possibly named after the issue or something understandable.
Next time, if there is an open issue then you may mention it in the commit message such as "FIX #24" so that the issue is automatically closed when we merge the PR.
Thanks for contributing.
from phpspreadsheet.
Related Issues (20)
- calculate error for CONCATENATE HOT 3
- Error reading file column into specific row HOT 5
- Crash while producing a spreadsheet with a reasonably complex HTML table that includes "<br>" tags. HOT 4
- Running via crontab on DigitalOcean - not saving HOT 1
- Time to build excel grows exponentialy HOT 4
- Reporting security vulnerabilities HOT 4
- Unable to access External Workbook HOT 4
- removeRow with merged Cells apply the same merging to the row below HOT 1
- Theme added to the table, cant be fetched in the functionality HOT 9
- Uncaught PhpOffice\PhpSpreadsheet\Exception: Spreadsheet objects cannot be json encoded in \app\ThirdParty\PHPOffice\PhpSpreadsheet\Spreadsheet.php:1519 HOT 3
- Data Validation HOT 2
- $reader->setTestAutodetect() not usefull when php version > 8.1 HOT 5
- Not able to add custom color in pie chart HOT 38
- Check if $header and $footer are not null
- Cannot set culumn width HOT 2
- Axis Bounds not Recognised Correctly HOT 2
- Unable to hide comments if saving using data that already contains VML drawings. HOT 2
- Incorrect Attribute Value for forceFullCalc in writeCalcPr Method HOT 2
- Your requested sheet index: -1 is out of bounds. The actual number of sheets is 1 HOT 3
- Bug in "Trunc" class HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpspreadsheet.