Comments (7)
I agree. Do you know a tool that could do that ?
from phpspreadsheet.
There is a sniff that checks all referenced names are imported via the use
in the Slevomat Coding Standard (SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly) but there is no automatic fix for it. I guess it is because there is no way to automatically handle the case when there are two classes with the same name in different namespaces.
from phpspreadsheet.
Hmm, it might be possible to automatically change this, or include it in PHP-CS.
from phpspreadsheet.
Yes, that is true. Okay, so only manually doing this is possible.
So this will change a lot files. How should I proceed to make this lesser painful [to reviewers]? For each "package" (namespace) a separate PR? Or per folder a separate PR (to keep them small)?
from phpspreadsheet.
@Quix0r I just examined the sniff I posted and I think I can make it auto-fixable for non-conflicting cases during this or next weekend if you are willing to wait :-)
from phpspreadsheet.
@jankonas sure, will wait here.
from phpspreadsheet.
Sorry for the delay, I don't have the time to do this right now. But Slevomat released v2.0 of their coding standard which now has the SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly sniff auto-fixable. So I suggest using it and keeping it in the project so it checks usage of uses in the future. Of course, many of the other sniffs have to be excluded to pass the checks.
from phpspreadsheet.
Related Issues (20)
- Chart: Not able to use multiple bar types (DataSeries::TYPE_BARCHART) in a single chart.
- Checking and converting loaded content in HTML Reader based on charset HOT 7
- Php 7.1 doesn't work with 1.11 and 1.12 versions (at least) HOT 1
- ZipStream error HOT 1
- Not able to write an xlsm file - phpoffice phpspreadsheet version 1.25.2 HOT 1
- Xml::loadSpreadsheetFromString() tries to open file when using falsy argument
- XML-Readers: Border Specification
- XML-Reader: support rich text HOT 1
- XML-Reader: interpret zoom
- PhpSpreadsheet can't retrieve images placed inside cell HOT 2
- Feature request: functionality to detect and read sheet tables and related styles HOT 6
- HTML export ignores setSize / getColor cell formats HOT 5
- v2.0.0 data corruption in non-UTF-8 apps as a result of dependency voku/portable-utf8 autoloader setting default_charset and mb_internal_encoding to "UTF-8" HOT 2
- Incorrect reader used for CSV files with BOM HOT 1
- The way to Protect only a particular cell is not working. How do i lock a particular row or column HOT 1
- Image can#t be inserted inside Cell, the same way as the newest Excel sheet or google sheet HOT 4
- Cannot read csv files that contain '<a href=' and do not have the extension ‘.csv’ ‘.tsv’.
- Textboxes, shape are not visible when using mergefields in file that contains image (Excel) HOT 1
- Conditional styles comming separates, even though two of them are one conditional style when you open the sheet HOT 1
- Conditional styles comming separates, even though two of them are one conditional style when you open the sheet HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpspreadsheet.