GithubHelp home page GithubHelp logo

Comments (4)

phyver avatar phyver commented on August 25, 2024 1

You're right, I am probably splitting hair...
I like using .bashrc instead of $GSH_CHEST/bashrc though.
Let's change only that.

from gameshell.

rlepigre avatar rlepigre commented on August 25, 2024

I'm not sure I fully understand what you are proposing. Do you mean:

  1. the "treasure" offering a .bashrc in the chest would be changed to have the .bashrc in $HOME,
  2. or do you mean that you would put a .bashrc in $HOME from the start?

If it is 1, then I don't see anything wrong with that.
If it is 2, then I am a bit worried that this could be puzzling for the player.

from gameshell.

phyver avatar phyver commented on August 25, 2024

I was proposing the second. (And the first as a consequence.)
My reasonning was that running bash from GameShell seems to take you "out" of GameShell, which is a little strange for a shell.
And I am also worried about puzzled player, but

  • no mission really takes place at the root of the world,
  • we can have a comment # DO NOT MODIFY THE NEXT LINE at the top of the file,
  • we can regenerate a correct .bashrc in start.sh, should it be missing.

The question is thus do we risk puzzling a player who's never heard of .bashrc, or do we try running a shell "as standard" as possible?

from gameshell.

rlepigre avatar rlepigre commented on August 25, 2024

Why not define an alias for bash then? I think that should solve the "take you out of GameShell" problem. At least if the user does not run /bin/bash, but if they know how to do that I don't think we care.

I think I prefer to keep things as they are with the following changes:

  • the fix I suggest above to prevent problems if the player runs bash,
  • move the .bashrc given as treasure to $HOME so that it is in the standard location. We could even explain that this is a standard configuration file in a comment in the file.

What do you think?

from gameshell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.