GithubHelp home page GithubHelp logo

Add signup endpoint about piccolo_api HOT 4 CLOSED

piccolo-orm avatar piccolo-orm commented on May 22, 2024
Add signup endpoint

from piccolo_api.

Comments (4)

sinisaos avatar sinisaos commented on May 22, 2024

@dantownsend I was thinking the same thing yesterday and it would be useful. Can I try implement this? My only question is how deep should we go with email and password validation without an external library. Is the html email field enough and is the 6-character password long enough? Or should we go deeper with regular expression?

from piccolo_api.

dantownsend avatar dantownsend commented on May 22, 2024

@sinisaos Thanks, it would great if you could take a look. Just a simple regex should be OK for email validation. Even if the first version is very simple, it's still useful. I think we can add hooks at some point, so users can add additional logic for password and email validation.

from piccolo_api.

sinisaos avatar sinisaos commented on May 22, 2024

@dantownsend I will make PR during the day that you can see code changes. We will drop a little bit in coverage because multiple lines like this one used to render errors in the HTML template. I think it's not a big deal.

from piccolo_api.

dantownsend avatar dantownsend commented on May 22, 2024

Implemented in #141

from piccolo_api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.