GithubHelp home page GithubHelp logo

Comments (14)

sinisaos avatar sinisaos commented on May 16, 2024 1

@dantownsend I'll do it in a few minutes.

from piccolo_api.

wmshort avatar wmshort commented on May 16, 2024 1

Excellent -- this is very helpful. Would it be possible also to give an example of how the CRSF token mechanism is supposed to work? Thanks

from piccolo_api.

sinisaos avatar sinisaos commented on May 16, 2024

@dantownsend Do you think of the whole app as in the Piccolo examples? If not your example from comment is perfect example of SessionAuth and that should be in docs.

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

@sinisaos The example code here might be sufficient.

I was thinking of a new page in the docs, with this code in it.

Screenshot 2021-09-07 at 13 59 21

The example code is an abbreviated form of one of my own apps - I haven't actually tested it standalone, but it looks correct.

What I'd love is if we had a new folder in the repo called examples. This file would be in there, and we'd somehow embed it within the docs.

I know Sphinx can be used to embed fragments of files, but I haven't tried embedding an entire file before.

At some point, we could add a unit test for the example app, to make sure it works.

from piccolo_api.

sinisaos avatar sinisaos commented on May 16, 2024

@dantownsend I have a question. I don't know anything about Sphinx's embed fragments of files, but I created a Piccolo Task starter app (based on your example) with SessionAuth where openapi docs are private and the home page is public. Everything works great, but I don’t know if I need to push the app to my Github repo and then you can put a link in the Piccolo examples or what to do with it? Thanks in advance.

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

@sinisaos I think it would be nice to embed the code directly in the docs.

I've figured out how to embed entire Python files:

Full example
============

.. include:: example.py
    :code: python

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

If you wanted to push your code to a new repo, I don't mind linking to it from the piccolo_examples repo.

But I'd still like to embed an example in the Piccolo API docs.

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

Thanks for checking the example code works.

from piccolo_api.

sinisaos avatar sinisaos commented on May 16, 2024

@dantownsend I made examples folder in SessionAuth directory in docs and then embed with

Full example
============

.. include:: ./examples/example.py
    :code: python

Result is:

example

Did you mean something like this or?

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

@sinisaos That's right - but can we put the example in it's own page?

from piccolo_api.

sinisaos avatar sinisaos commented on May 16, 2024

@dantownsend Yes we can.
Index page

index

Full example page

example

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

@sinisaos That's great, thanks

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

If you open it as a PR, I'll get it merged.

from piccolo_api.

dantownsend avatar dantownsend commented on May 16, 2024

Fixed by #86

from piccolo_api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.