“picgo upload" to uplad the first image at clipboard will crash in Win 10 about picgo-core

[Molunerfinn]

You can find the log file in the same folder of the config file. The log file is picgo.log

[Molunerfinn]

I can't reproduce in my Mac.

I have to look at your log file for more details

[Leslie-Wong-H]

The picgo.log file remains unchanged, but I managed to capture the crash event at Event Viewer when executing "picgo upload".

提供程序“Registry”为 Started。

详细信息:
ProviderName=Registry
NewProviderState=Started

SequenceNumber=1

HostName=ConsoleHost
HostVersion=5.1.18362.628
HostId=7b77d0c9-eca8-4e0e-86dc-1419805a2b21
HostApplication=powershell -noprofile -noninteractive -nologo -sta -executionpolicy unrestricted -windowstyle hidden -file C:\Users\79917\node_modules\picgo\dist\src\utils\clipboard\windows10.ps1 C:\Users\79917\.picgo\20200309145807.png
EngineVersion=
RunspaceId=
PipelineId=
CommandName=
CommandType=
ScriptName=
CommandPath=
CommandLine=

[Leslie-Wong-H]

提供程序“Alias”为 Started。

详细信息:
ProviderName=Alias
NewProviderState=Started

SequenceNumber=3

HostName=ConsoleHost
HostVersion=5.1.18362.628
HostId=7b77d0c9-eca8-4e0e-86dc-1419805a2b21
HostApplication=powershell -noprofile -noninteractive -nologo -sta -executionpolicy unrestricted -windowstyle hidden -file C:\Users\79917\node_modules\picgo\dist\src\utils\clipboard\windows10.ps1 C:\Users\79917\.picgo\20200309145807.png
EngineVersion=
RunspaceId=
PipelineId=
CommandName=
CommandType=
ScriptName=
CommandPath=
CommandLine=

[Leslie-Wong-H]

提供程序“Environment”为 Started。

详细信息:
ProviderName=Environment
NewProviderState=Started

SequenceNumber=5

HostName=ConsoleHost
HostVersion=5.1.18362.628
HostId=7b77d0c9-eca8-4e0e-86dc-1419805a2b21
HostApplication=powershell -noprofile -noninteractive -nologo -sta -executionpolicy unrestricted -windowstyle hidden -file C:\Users\79917\node_modules\picgo\dist\src\utils\clipboard\windows10.ps1 C:\Users\79917\.picgo\20200309145807.png
EngineVersion=
RunspaceId=
PipelineId=
CommandName=
CommandType=
ScriptName=
CommandPath=
CommandLine=

[Leslie-Wong-H]

[Leslie-Wong-H]

[Leslie-Wong-H]

[Leslie-Wong-H]

[Leslie-Wong-H]

[Leslie-Wong-H]

[Leslie-Wong-H]

Hope this help.

[Molunerfinn]

Not help. Maybe you can clone the repo, install and run npm run dev into the dev mode, then add some console.log into the Lifecycle.ts to see what happened.
Then use node ./bin/picgo upload to upload and see the log

[Leslie-Wong-H]

Add these log commands.

      // lifecycle main
      console.log("To run 'beforeTransform'");
      await this.beforeTransform(this.ctx);
      console.log("'beforeTransform' ends");
      console.log("To run 'doTransform'");
      await this.doTransform(this.ctx);
      console.log("'doTransform' ends");
      console.log("To run 'beforeUpload'");
      await this.beforeUpload(this.ctx);
      console.log("'beforeUpload' ends");
      console.log("To run 'doUpload'");
      await this.doUpload(this.ctx);
      console.log("'doUpload' ends");
      console.log("To run 'afterUpload'");
      await this.afterUpload(this.ctx);
      console.log("'afterUpload' ends");
      return this.ctx;

And the result is

Any problem with your windows.ps1 or windows10.ps1 file?

[Molunerfinn]

Never change the files above in the recent releases. That's wired. Maybe you can check the .picgo folder to see if the windows.ps1 and windows10.ps1 exists and files not broken

[Leslie-Wong-H]

Yet it works with the selected image.

Is there any clipboard logic change because of win 10 update?

[Molunerfinn]

Nope. Clipboard image uploading depends on windows10.ps1 and getClipboardImage and not change in recent releases.

[Molunerfinn]

you can run the script with your powershell:

notice the -xx below should use the option in getClipboardImage.ts

powershell -noprofile -xxx -xx -xx -file windows10.ps1 imagepath

And see what happened. I think it maybe the powershell's problem.

[Leslie-Wong-H]

Ran this command and a binary file was generated. Is the parameter "imagepath" right?

[Molunerfinn]

hmmmmmmmmm, imagePath is a png image filename. Such as xxx.png

https://github.com/PicGo/PicGo-Core/blob/dev/src/utils/getClipboardImage.ts#L25

powershell -noprofile -xxx -xx -xx -file windows10.ps1 test.png

And you should capture a picture before running this script.

If a png file is generated, then the script is no problem and not a problem with picgo. So maybe it's the system permission issues

[Leslie-Wong-H]

After a long time of consecutive debug grinding, I finally caught the root of this crash bug, which is the wrong use of PowerShell command.

According to page159 of Ed Wilson's Windows PowerShell 3.0 First Steps, a Microsoft Press book, it states that in order to keep the PowerShell console open you have to add parameter "-noexit" before running the PowerShell scripts. Screenshots are as follows.

In the case of picgo-core, the getClipboardImage.ts needs to read output from the PowerShell script execution, yet it is impossible to read output if the intrinsic PowerShell console close automatically after running windows10.ps1, so you need to add "-noexit". And in my debug grinding, you also need to comment "-windowstyle" and "hidden", although I still don't know the reason, it works eventually.

Here it is.

[Molunerfinn]

Will this change cause the powershell window to open explicitly?

It is expected that image uploading will be performed without disturbing the user. Is this consistent with the previous experience after adding this parameter?

And this script has always been normal before, that's wired.

[Leslie-Wong-H]

Run in CMD and no PowerShell console will explicitly pops up.

In my guess, your acquiring the clipboard implementation from vs-picgo, which mainly takes advantage of the integrated CMD terminal of vscode, leads to the ignorance of use of picgo-core clipboard outside of vscode's integrated cmd terminal. Therefore, when Typora officially acquires picgo-core and provides documentation, this potential problem becomes apparent, because Typora users using picgo-core need to add custom command, and the custom command calls the native cmd, not integrated one, thus it does not behave like vscode's.

In vscode's integrated cmd terminal, it makes no difference to add '-noexit' or not, maybe for some customized mechanism.

[Molunerfinn]

Run in CMD and no PowerShell console will explicitly pops up.

In my guess, your acquiring the clipboard implementation from vs-picgo, which mainly takes advantage of the integrated CMD terminal of vscode, leads to the ignorance of use of picgo-core clipboard outside of vscode's integrated cmd terminal. Therefore, when Typora officially acquires picgo-core and provides documentation, this potential problem becomes apparent, because Typora users using picgo-core need to add custom command, and the custom command calls the native cmd, not integrated one, thus it does not behave like vscode's.

In vscode's integrated cmd terminal, it makes no difference to add '-noexit' or not, maybe for some customized mechanism.

Nice, if the user experience is the same as before, then I should merge your PR. Did you test in Typora?

[Leslie-Wong-H]

CMD test result:

[Molunerfinn]

But it will block the console and will not exit?

[Leslie-Wong-H]

Thanks for point out my ignorance of the cursor. Refer to this Stack Overflow problem and finally find a solution from Joe Johnston's comment.
How to exit PowerShell.exe inside of CMD
The right way to fix the bug is as follows.

#windows10.ps1 
function main{
      .....

      $imagePath
      # fix windows 10 native cmd crash bug when "picgo upload"
      # https://github.com/PicGo/PicGo-Core/issues/32
      Exit 1
}

execution = spawn('powershell', [
        '-noprofile',
        '-noninteractive',
        '-nologo',
        '-sta',
        '-executionpolicy', 'unrestricted',
        // fix windows 10 native cmd crash bug when "picgo upload"
        // https://github.com/PicGo/PicGo-Core/issues/32
        // '-windowstyle', 'hidden',
        // '-noexit',
        '-file', scriptPath,
        imagePath
      ])

[Leslie-Wong-H]

CMD test result:

Before fix:

Then crashes.

After Fix:

[Molunerfinn]

Thanks for your contribution!