TAG issues about vsmr

[sw104]

Hi Simon,

With regard to the actions when you click the tag items, I believe that these were changed so that you have to right-click the items instead of left-clicking them.

I'll leave the other points for Pierre to answer! ;-)

[Koploper9]

Hi

Unfortunately I already knew en tried that :-(. But thanks for the answer anyhow :-)

[kusterjs]

To change the position of the label in the approach window, click on the target and it will switch to the next position. There is no option to drag the label freely. This is a solution used in different real life systems and makes it quite easy for controllers to organize their labels.

[pierr3]

I probably messed up calculating the bounding box for the click items when I changed the tag drawing system, sorry about that

[Koploper9]

@kusterjs Thanks, that works!
@pierr3 Ok, once you are used to it, it isn't a big deal.

[LB767]

I think I may have found the problem, I need to test it live on ES to see if that's really it.
The text click spots seem do be drawn before the actual tag click spot, which ends up being on top of everything.
Basically it does AddScreenObject(TagClickableMap[element], ... before AddScreenObject(DRAWING_TAG, ...
The order was inverted before the tag refactoring update.

[pierr3]

@LB767 Can you test your fix, and if it works could you create a pull request?

[LB767]

@pierr3 Oh I had already tested it and it was indeed that. You already merged it :)
Though I think there might still be something odd with the click and drag of tags sometimes, not exactly sure what.

[pierr3]

@LB767 My bad, my memory failed me, I'll recompile asap and post the update.

[pierr3]

The nightly build is out, could anyone check if Lionel fixed it?
https://ci.appveyor.com/api/projects/pierr3/vSMR/artifacts/vSMR-nightly.zip

[LB767]

I just noticed there's still a bug somewhere as I can't click&drag the tag if it's uncorrelated. Will have to look into that...

[pierr3]

Fixed thanks to @LB767 in #29