GithubHelp home page GithubHelp logo

Comments (2)

piersdeseilligny avatar piersdeseilligny commented on August 30, 2024

@rickschubert sounds good! I don't really have any experience with this but you're right, it definitely wouldn't be a bad thing. I've added you as a collaborator.

from betterfountain.

rickschubert avatar rickschubert commented on August 30, 2024

I will close this ticket for now as well as my pull request. I wanted to open it as an issue to see how your opinion is but it actually isn't really an issue, more a feature suggestion. I will close my pull request #73 for now. The pipeline itself was set up and working, but the tests aren't passing anymore - and nobody wants to merge in a pipeline with failing tests.

I had a glimpse at fixing the tests but since the screenplay statistics now also require the afterparser to run as well as the PDF creation, the tests can't run in isolation anymore and would have to be run on a VSCode host. I might look into it in my spare time out of personal interest but want to close it for now so as to not have a stale pull request on the repository and thereby maybe give the impression to other contributors that contributions wouldn't be welcome.

from betterfountain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.