GithubHelp home page GithubHelp logo

Do not build CLI images about docker HOT 7 CLOSED

pimcore avatar pimcore commented on July 28, 2024 1
Do not build CLI images

from docker.

Comments (7)

dpfaffenbauer avatar dpfaffenbauer commented on July 28, 2024 2

@jdreesen the new multistage builds are much smaller as they share much more layers

from docker.

jdreesen avatar jdreesen commented on July 28, 2024 1

Do they? How can I see that? For me, not much seems to have changed:

REPOSITORY                     TAG                  IMAGE ID       CREATED         SIZE
pimcore/pimcore                PHP8.1-cli           1af7d21f6c68   10 hours ago    2.81GB
pimcore/pimcore                PHP8.1-fpm           ad914ab4f56f   11 hours ago    2.77GB

/edit:

Alright, the new images weren't ready. Now both are the same size and the CLI image didn't need to pull anything, because the FPM image was already pulled.

REPOSITORY                     TAG                  IMAGE ID       CREATED         SIZE
pimcore/pimcore                PHP8.1-cli           e67ad21525e1   3 hours ago     2.77GB
pimcore/pimcore                PHP8.1-fpm           e67ad21525e1   3 hours ago     2.77GB

from docker.

yariksheptykin avatar yariksheptykin commented on July 28, 2024

Sound like a good idea to me. I use fpm flavor for executing pimcore CLI commands.

from docker.

dpfaffenbauer avatar dpfaffenbauer commented on July 28, 2024

I use the CLI build for workers

from docker.

NiklasBr avatar NiklasBr commented on July 28, 2024

Docker images can share layers as I understand it, so there could be some overlap, the sum of storage may not be 449+484MB right?

from docker.

jdreesen avatar jdreesen commented on July 28, 2024

I assume we won't be able to share the relevant layers if we use the official PHP CLI & FPM images as base, because most of the size comes from the many pimcore dependencies and the shared layers are only those before the PHP ones, no?

from docker.

brusch avatar brusch commented on July 28, 2024

Done by #98 and follow-up commits -> cli is now an alias on fpm.

from docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.