GithubHelp home page GithubHelp logo

Comments (5)

pimterry avatar pimterry commented on May 29, 2024 2

I can reproduce this, in codesandbox but also locally by exporting that same demo.

Testing it manually with a debugger, in fact it's the console.log that's wrong here - that App() method really is called twice.

It turns out that in React v17 a recent feature hides the output of console.log during a new second rendering pass. That hides the console.log output, but not loglevel's output, which holds a reference to console.log from beforehand.

More detail available in facebook/react#21783. This was fixed (moving the logic to React itself into React devtools, and showing the output but greyed out) in facebook/react#22030, but it sounds like that will only be included in React v18, not v17.

I'm going to close this - loglevel is working correctly, this is a React issue.

from loglevel.

gaearon avatar gaearon commented on May 29, 2024 1

React 18 is out, and double logs are no longer suppressed by default.
(But they're slightly dimmed if you have DevTools installed.)

See facebook/react#21783 (comment).

from loglevel.

pimterry avatar pimterry commented on May 29, 2024

I'm not aware of anything that could cause this. It's hard to debug this in more depth without a repro though. Can you share a playground or similar where I can test this behaviour myself?

from loglevel.

rsi-yhe avatar rsi-yhe commented on May 29, 2024

https://codesandbox.io/s/empty-sun-5loi1?file=/src/App.js
I put two logs inside App.js and you can see console have 2 output from loglevel
Screen Shot 2021-10-12 at 9 41 20 AM

from loglevel.

pimterry avatar pimterry commented on May 29, 2024

Great, thanks for the update @gaearon!

from loglevel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.