Automate auth type detection about vdirsyncer

[geier]

vdirsyncer could figure out by itself if the server wants basic or digest auth, removing that config option or at least make it optional (user's often don't know what their CalDAV server wants). Most other clients don't need any information on that, making it not very far spread knowledge.

Also it should be rather easy to implemenet as the server sends WWW-Authenticate: Digest [...] or WWW-Authenticate: Basic [...].

[untitaker]

I thought this could actually be a neat feature for requests, so i filed it there: https://github.com/kennethreitz/requests/issues/2006

[geier]

Great, I'll keep an eye on that one.

[untitaker]

A relevant pull-request has been merged into requests-toolbelt at requests/toolbelt#28. The question is: Should we start to depend on requests-toolbelt for this, or just inline the relevant code? I don't think depending on a not very popular library is really justified if we only need such a small portion of its functionality, but OTOH it is less maintenance for me.

[untitaker]

Thinking another ten seconds about it i came to the conclusion that depending on that package is better as it uses some lower-level parts of request's API which i am not comfortable dealing with.

[sigmavirus24]

@untitaker also, the toolbelt is (unfortunately for my free time) more popular than you might think.

[untitaker]

I meant, relative to the other dependencies of vdirsyncer: requests, lxml...

[untitaker]

Well, leif is not popular at all, but i am using 100% of its code, so it's okay. icalendar contains logic i don't ever want to maintain, so that's okay too.

[untitaker]

Done, last related commit in 308ac53.