[Proposal]Add version in tidb about tidb

[ngaut]

We have already support version. https://github.com/pingcap/tidb/blob/master/util/printer/printer.go#L23

[astaxie]

That's weird. Why put the version in the util package? From the structure it's not make sense.

[ngaut]

We may use it in interpreter. MySQL protocol layer. Or HBase engine.
Put to util package, so we keep it DRY.

[astaxie]

You mean you will use the version in many other packages? Then the version is out of control. 😸

[ngaut]

WOW, User could pass version information to those variables :)

[xiang90]

@ngaut Well... You can make then read-only.

[ngaut]

It's read only after assignment.

[c4pt0r]

any updates? @ngaut

[ngaut]

@astaxie

[astaxie]

I have no idea on the version now. AFAIK https://github.com/pingcap/tidb/blob/master/util/printer/printer.go#L23 looks not good enough.

[unknwon]

+1

Need something like Version() around here, and it should return semantic version, so app can check it in case a bug was introduced in older version but fixed in newer one.

[fuxiaohei]

the version number is useful to version control.

Now I find that if tidb code updated, the old goleveldb data directory can't load.

So I need lock a version to make sure to develop and compile.

[ngaut]

Currently TiDB is evolving extremely fast. The version information is generated automatically by makefile:

LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBBuildTS=$(shell date -u '+%Y-%m-%d %I:%M:%S')"
LDFLAGS += -X "github.com/pingcap/tidb/util/printer.TiDBGitHash=$(shell git rev-parse HEAD)"

Does that sound ok? @fuxiaohei