QOL changes about snappass

[devinlundberg]

For 1) autocomplete="off" should prevent this. It looks like we have that property applied to the textarea tag instead of the form tag. Moving it to the right html tag should resolve the issue and is likely a better solution than a javascript based one (since some users could have js disabled as you call out).

For 2) I don't know of a better solution and a javascript solution sounds reasonable (this doesn't actually break anything if javascript is disabled). Many browsers do warn that you are about to resubmit the form for refresh on POSTs and I'm able to reproduce this warning on chrome with snappass so I think this is the least impactful issue you flagged.

For 3) I think a server-side solution to not generate links for empty data might be best here. Should a be a simple if statement. We could also add the required property to the form field to prevent this client side.

[bensharp1]

These all sound good.

I have just moved the autocomplete='off' to the form tag, and that has resolved that issue even with Javascript disabled as you say.

Having both a server-side and client-side solution for 3) would be great.

[jparise]

@bensharp1 would you mind opening a Pull Request for that autocomplete="off" change given that you've successfully verified that approach?

[nichochar]

Closing this, as these were addressed, merged and deployed in 1.4.2