Comments (4)
Mutability is referring to whether any of the fields of face need to change when that method is called. Although some internal state might change in the freetype library code, the Face struct itself does not need to change.
from freetype-rs.
Some projects such as glfw-rs
use &mut self
even for methods that don't modify struct fields. See PistonDevelopers/glfw-rs@6b5c2fe for an example. It seems like we should follow that example. For one thing, it's conceivable that at some point we might want to change some of those methods so that they do change fields, which would require switching to &mut self
anyway. I'd rather not risk having to break the API like that.
from freetype-rs.
I asked in #rust-internals about this, and was told the calling order of FFI functions won't be affected.
from freetype-rs.
This seems like an issue similar to when to use unsafe
, which also has grey areas in library design. I can't tell which way is right, because there could be different contexts where either case is wrong. The argument in favor of using &mut self
is that the API breaks less code when doing &mut self => &self
, than &self => &mut self
. If we suspect we will run into this issue and there is no context we can think of when &self
is better, then I think we should use &mut self
.
from freetype-rs.
Related Issues (20)
- FFI error compiling freetype-rs as dependency HOT 1
- Implement std::error::Error for freetype::error::Error
- Publish 0.2.0 version on crates.io HOT 3
- Fix implementation of a 'Display' trait for the 'Error' type
- Crate not usable on arm/android any more HOT 6
- Relicense under dual MIT/Apache-2.0 HOT 19
- The single_glyph example might crash HOT 2
- SVG Glyphs in OpenType Specification
- Example outdated?
- CurveIterator is wrong with curves starting with OFF point HOT 1
- Support Stroker
- Expose global bbox
- Segfault during glyph outlining HOT 1
- Dropping BitmapGlyph created by Glyph::to_bitmap invalidates the Glyph and causes segfault HOT 5
- Glyph::to_bitmap creates duplicate pointer if the glyph was already rendered during `Face::load_char`.
- Printing `Error` recurse infinitely
- sample single_glyph problem for j
- [Question] why do we need to `FT_Done_Library` in `impl Drop for Glyph` and `impl Drop for Face` HOT 1
- Upkeep: Should this code migrate to 2021 edition?
- Render modes missing FT_RENDER_MODE_SDF HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from freetype-rs.