No support for SOCKS 5 proxies about pithos

[TheKrafter]

I'd very much appreciate socks5 support, i host a socks5 proxy and would like to listen to pandora at work (where it's blocked)

[Jesse-V]

The workaround is:

$ torify pithos

I think you need to have torsocks installed.

[heniokalinowski]

I am using right now browser with TOR to listen Pandora and it works.

I have tried
$ torify pithos
it does log me in, id does display songs, but hangs on buffering 0% as well as nothing can be clicked (same as when You do heavy computing in main thread).
I get in terminal spam of messages like:

[Jul 26 19:28:11] WARNING torsocks[24223]: [syscall] Unsupported syscall number 204. Denying the call (in tsocks_syscall() at syscall.c:465)
[Jul 26 19:28:11] WARNING torsocks[24223]: [syscall] Unsupported syscall number 204. Denying the call (in tsocks_syscall() at syscall.c:465)
[Jul 26 19:28:11] WARNING torsocks[24223]: [syscall] Unsupported syscall number 204. Denying the call (in tsocks_syscall() at syscall.c:465)

Also, it causes memory leak for me.
Linux Mint 18 x64 Cinnamone, stable repository

Maybe it would be better, to build-in support for listening from outside of USA like in this project:
https://github.com/PromyLOPh/pianobar

[TingPing]

Seems like it should be pretty easy to use PySocks.

https://github.com/Anorov/PySocks/blob/master/sockshandler.py

[infirit]

Recent requests module supports SOCKS through the additional PySocks dep. Perhaps worth the contemplating moving to it.

[TingPing]

Well since requests literally just uses PySocks too, so its only more work than us using it directly.

[TingPing]

I pushed a simple test for socks5 here: https://github.com/pithos/pithos/tree/wip/socks

I only implemented it for the control proxy atm but if somebody wants to test it I might finish it up.

[sunng87]

@TingPing may I ask what's the status about socks branch?

[TingPing]

It just needs to be tested.

[vectro]

I merged wlp/socks to master (in my local repository) but it didn't work.

• The main problem is in Pandora.build_opener(), the last line of which should be like this:
  return urllib.request.build_opener(*(handlers + (https,)))
• The ImportError catch is probably not sufficient, as we then pass None to build_opener(), which causes a TypeError inside urllib (and anyway the print goes to the console, which is usually invisible).

[TingPing]

@vectro Please do open a PR with a working version.