[BUG] 'permitted_licenses add' not working properly for all licenses using spdx-id format. LGPL and Python for sure. about licensefinder

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[swarren12]

From what I can tell, the defined spdx_id field is currently entirely ignored when attempting to match a license.

However, some licenses happen to also include the SPDX identifier in the other_names list. This is the case with the Apache-2.0 example.

Changing the matching logic of License::matches_name? to include the spdx_id field should resolve this.

I've raise a PR for this change.