GithubHelp home page GithubHelp logo

SECURITY issue about piwigo-social-connect HOT 4 OPEN

timaschew avatar timaschew commented on July 2, 2024
SECURITY issue

from piwigo-social-connect.

Comments (4)

mistic100 avatar mistic100 commented on July 2, 2024

Hello,

how exactly is this a security issue ? Neither the security of the gallery or the Google account of the user is compromised at any moment.

The only "problem" is that the administrator is not sure the provided email corresponds to the linked account. And in my opinion this is a good thing, the user must be able to authenticate with an external provider but do not give you his main email, he can choose what personnal information he gives to you *

You will also notice that in the the standard Piwigo authentication the email is not mandatory and is not verified.

* This is in accordance to the GDPR and any data protection laws.

from piwigo-social-connect.

mistic100 avatar mistic100 commented on July 2, 2024

I must precise that the email is not used in the authentication process.

from piwigo-social-connect.

timaschew avatar timaschew commented on July 2, 2024

But then I don't get the idea of permissions and groups, how can I add user to a group if I can't ensure the identity of that user? Which is usually given by the email address with either a activation link or via an external provider.

from piwigo-social-connect.

timaschew avatar timaschew commented on July 2, 2024

The only "problem" is that the administrator is not sure the provided email corresponds to the linked account. And in my opinion this is a good thing, the user must be able to authenticate with an external provider but do not give you his main email, he can choose what personnal information he gives to you

That's exactly my point. I'm okay if you say the external provider should not give the email, but then you should not allow the user to specify any email address he wants, just disable that input field then.

But currently the email address is passed by the provider because the input field is prefilled with my address, but I can change it.

from piwigo-social-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.