Performance issues about graphics-smooth

[dev7355608]

@ivanpopelyshev Is this (da1c536) ok?

[dev7355608]

@9a-aaaaaaaa Make sure you don't unnecessarily redraw the graphics when you just want to change the position of it. I couldn't observe anything abnormal like that unless the graphics was redrawn with a new instance of the dash line shader.

I released the fix.

[ivanpopelyshev]

we can remove it

[Amoki]

Can it be related to pixijs/pixijs#7583 ?

[ivanpopelyshev]

You re-create graphics often, right? hmmm... It looks like shader caching doesnte work properly

[dev7355608]

Probably because a new program is created for each dash line shader:

graphics-smooth/src/DashLineShader.ts

Line 55 in 8e6e5db

super(settings, new SmoothGraphicsProgram(settings, undefined, dashFrag),

We should add SmoothGraphicsProgram#fromSettings(settings, vert, frag), which constructs the sources and then calls Program.from(vert, frag).

[ivanpopelyshev]

oh, yes, it was experimental and i didnt cache it. @dev7355608 agree

[dev7355608]

@ivanpopelyshev SmoothGraphicsProgram#from doesn't return the program as an object of class SmoothGraphicsProgram. That is annoying. Is an extract subclass of Program really necessary or can we remove it?

[9a-aaaaaaaa]

You re-create graphics often, right? hmmm... It looks like shader caching doesnte work properly

Like Figma, I encountered this problem when I moved the graphics. I didn't create the graphics multiple times while moving, just changing positions.

[9a-aaaaaaaa]

Can it be related to pixijs/pixijs#7583 ?

I'm not sure, I was just creating the graphics using graphics-smooth and I ran into this problem when I moved the graphics around. I think it's the same kind of problem.

[9a-aaaaaaaa]

we can remove it

Will there be any other effects of removal? If removing it makes this performance better, look forward to it. many thanks.

[ivanpopelyshev]

@dev7355608 looks ok

[9a-aaaaaaaa]

@9a-aaaaaaaa Make sure you don't unnecessarily redraw the graphics when you just want to change the position of it. I couldn't observe anything abnormal like that unless the graphics was redrawn with a new instance of the dash line shader.

I released the fix.
Wow, thank you very much. It's amazing.