GithubHelp home page GithubHelp logo

Comments (4)

davidye avatar davidye commented on April 28, 2024

@Zyie @GoodBoyDigital

One thought I had was that the visible property is being overloaded. Perhaps there should be a separate culled property that is independent of visible.

For example I may want to mark a node with visible = false and that toggles in response to user input. With this implementation of culling, which uses visible directly, I would need to explicitly set node.visible = true / false before every call to Culler.shared.cull().

Culling should probably not overwrite visible in this way because it's more of an optimization detail that changes from render() to render(), not a state of the node?

from pixijs.

Zyie avatar Zyie commented on April 28, 2024

hey @davidye i've added a pr to add a new property so it no longer overrides visible. Let me know if this solves your issues

from pixijs.

davidye avatar davidye commented on April 28, 2024

@Zyie 🙏 thank you! Will test once the new rc is published.

from pixijs.

davidye avatar davidye commented on April 28, 2024

Working great now, thank you!

from pixijs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.