GithubHelp home page GithubHelp logo

Comments (4)

dgrigsby avatar dgrigsby commented on August 26, 2024

The problem appears to be in cbor_encode_half.
"exp" is -14 (which is correct), represented in a byte as 0xf2.
Then this is interpreted as passing the if (exp > 15) test at line 147.
A zero is returned, which causes cbor_serialize_alloc to uselessly resize the buffer and try again.
The screenshot below shows the sordid details.
cbor3

from libcbor.

dgrigsby avatar dgrigsby commented on August 26, 2024

This may mean you can't encode any half-float between 0 and 0.5.

from libcbor.

PJK avatar PJK commented on August 26, 2024

Hi @dgrigsby,

I'm not sure this problem has to do with endianess -- I've added all the examples to the test suite (075cdbf) and they seem to pass on x86 machines.

Could you please describe the complete setup/XCode config?

Thank you!

from libcbor.

PJK avatar PJK commented on August 26, 2024

You were right, there was a problem in how the encoding works. Until there is a native way to represent half floats in C, it will remain a compromise, but I've updated the encoding so that it always produces a reasonable value.

#49 together with #50 should resolve your issue.

from libcbor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.