Comments (8)
I'll look into the upgrade and perf. improvement. Thx for raising attention to
this.
regards,P.
Original comment by [email protected]
on 6 Mar 2013 at 7:25
- Changed state: Accepted
from protobuf-rpc-pro.
i have to wait a bit for the 2.5.0 to be released to maven central.
Original comment by [email protected]
on 7 Mar 2013 at 5:57
from protobuf-rpc-pro.
Here is the ticket for it to be added
https://code.google.com/p/protobuf/issues/detail?id=478
Original comment by [email protected]
on 7 Mar 2013 at 6:20
from protobuf-rpc-pro.
i did an upgrade to 2.5.0 locally and replaced the netty ProtobufDecoder (with
FastProtobufDecoder attached) to use the PARSER instead of the message builder.
Unfortunately i couldn't prove that there was any significant performance
improvement. Maybe this is because the WirePayload i'm serializing is not very
complex - primarily just a ByteString.
Since i'd like to keep Netty & Protobuf libraries "in-line", i'd prefer to wait
for Netty to upgrade their support for 2.5.0 and i'll upgrade to the new netty
version and protobuf 2.5 at the same time.
It would be interesting if Netty developers could test / try to see if they can
confirm the alleged performance increase of using PARSER.
I checked in my performance test client into the "demo" project.
If you really want the upgrade sooner, just say.
Original comment by [email protected]
on 8 Mar 2013 at 8:03
Attachments:
from protobuf-rpc-pro.
Thanks for looking into it. I will check performance in my test case and get
back with you.
Original comment by [email protected]
on 9 Mar 2013 at 7:28
from protobuf-rpc-pro.
Upstream is open to a pull request:
https://github.com/netty/netty/issues/1138#issuecomment-14669707
Original comment by [email protected]
on 9 Mar 2013 at 8:21
from protobuf-rpc-pro.
The change is merged in to netty 4.0. If protobuf 2.5 is available then it
will use the Parser, else it defaults back to the old behavior.
See this commit:
https://github.com/netty/netty/commit/c25513d5e1dd8eb9906989e83a1ce41495d3e6a9
This ticket can be blocked by ticket #16 (upgrade to netty 4.0) and becomes
just changing you dependency to protobuf 2.5 if that sounds good to you.
Original comment by [email protected]
on 12 Mar 2013 at 12:26
from protobuf-rpc-pro.
Upgraded to 4.0.0.Beta2 in 3.0.3 version.
Original comment by [email protected]
on 16 Mar 2013 at 11:16
- Changed state: Fixed
from protobuf-rpc-pro.
Related Issues (20)
- async call's timeout not really work HOT 3
- Support Java 6 HOT 3
- RpcServiceRegistry cannot remove BlockingService HOT 1
- Protocol Buffers 2.6 HOT 7
- Disabling logging HOT 3
- Python rpc support HOT 1
- Upgrade to protobuf-java 3.0.0 ( after Netty ) HOT 3
- maven not building for project HOT 3
- protoc plugin that is being used HOT 4
- Using Websockets HOT 1
- CleanShutdownHandler to shutdown RpcClientConnectionWatchdog
- RpcClientChannel support "attributes" and isClosed method.
- CleanshutdownHandler leaves Thread prohibiting JVM shutdown HOT 1
- Allow RpcClientChannel attributes on client peerWith HOT 1
- CleanShutdownHandler leaves shutdown hook registered when shutdown explicitly HOT 1
- Is this project stable enough to use in production environment? HOT 2
- WatchdogThread is not renamed to a readable thread name HOT 2
- StackOverflowError DuplexTcpClientPipelineFactory.peerWith HOT 4
- C++ impl? HOT 1
- Compile Fail by Not Found AsyncThreadPoolCallExecutor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf-rpc-pro.