client port not correct about protobuf-rpc-pro

[GoogleCodeExporter]

yes, you're right. I have not been completely satisfied with this behaviour for 
a long time. I have solved this now by altering the constructor of 
DuplexTcpClientPipelineFactory to not have a PeerInfo in the constructor, and 
then depending on whether a setClientInfo is done or not - we use the provided 
local host/port for client side binding. If no specific client side binding is 
provided, then any new available local port is bound. In both cases, we set the 
RpcClient's port to be the locally attached port, so your code above is 
respected still. 

Since the binding semantics have changed, i deliberately made it so the 
existing constructor of DuplexTcpClientPipelineFactory will break the code, so 
people have to choose explicitly how they want to handle the client side port 
binding. This change could make setting the "localAddress" on netty's Bootstrap 
not necessary anymore since their localAddress is not used anymore.

Fixed with 3.2.

Pls give feedback if it's ok for you.

Original comment by [email protected] on 15 Jan 2014 at 8:40

• Changed state: Fixed

[GoogleCodeExporter]

Thanks very much, it is good for me.

Original comment by [email protected] on 16 Jan 2014 at 7:15

[Marax]

Hi, since this change, we are having issue with connecting on Centos 7 and java8.

We are unable to connect only when we specify hostname to clientInfo and there is no record in /etc/hosts with .

If we don't specify the clientInfo to bootstrap, it connects, but on the server side client is stored with his IP and our current solution expects hostname.

I'll try to make minimal example and update here later.

[pjklauser]

Hi Roman, please create a new Issue and describe the problem you're having
here. I'm interested in checking if this is a potential java8 migration
issue or OS related.

thanks;Peter.

---

From: Roman Mařák [mailto:[email protected]]
Sent: Donnerstag, 9. Juli 2015 10:59
To: pjklauser/protobuf-rpc-pro
Subject: Re: [protobuf-rpc-pro] client port not correct (#30)

Hi, since this change, we are having issue with connecting on Centos 7 and
java8.

We are unable to connect only when we specify hostname to clientInfo and
there is no record in /etc/hosts with .

If we don't specify the clientInfo to bootstrap, it connects, but on the
server side client is stored with his IP and our current solution expects
hostname.

I'll try to make minimal example and update here later.

Reply to this email directly or view
<#30 (comment)
261> it on GitHub.
<https://github.com/notifications/beacon/ABl1LX4awNi48TNi1IT45b-tqYSBQyoNks5
obi89gaJpZM4FVGWu.gif>

---

This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus