GithubHelp home page GithubHelp logo

Multi-modal profiling about profile HOT 11 CLOSED

pkg avatar pkg commented on August 28, 2024 5
Multi-modal profiling

from profile.

Comments (11)

bygui86 avatar bygui86 commented on August 28, 2024 2

@klauspost as my changes are pretty extended, I decided to create a complete new module.
You can find it here: https://github.com/bygui86/multi-profile
Looking forward your feedback!!

If the maintainers of this amazing module want to reach me to discuss the merge our projects, I would be more than happy :)

from profile.

davecheney avatar davecheney commented on August 28, 2024

from profile.

jcorbin avatar jcorbin commented on August 28, 2024

Thank you for the detailed request. Sadly the answer is no. I encourage you to fork this project and making the changes you want.

Fair enough, and this was pretty much the answer I expected to get btw, but I thought I'd try the Talk option before the Code option ;-)

In the interest of posterity, could you please share your thoughts on why writing out already taken profile counts (from passive profiles as I described above) after active profile stop wouldn't be something that you'd be willing to accept for pkg/profile? I totally get wanting active profiling to be exclusive (e.g. CPU and Trace at least; someone cranking up the memory profiler rate could also count, especially since you have that path carved out as a separate functional option...)

from profile.

bygui86 avatar bygui86 commented on August 28, 2024

@davecheney I'm working on an evolution of your profile package.
If you have time, it would be great you to have a look at it :)
I'm still working on the testing part, but I committed the implementation right today.
Here the link https://github.com/bygui86/profile

Thanks

from profile.

klauspost avatar klauspost commented on August 28, 2024

@bygui86 Did you abandon it? I don't see any changes in your fork?

from profile.

mmcloughlin avatar mmcloughlin commented on August 28, 2024

I've had a go at this and pushed up work-in-progress to my experimental repo:

https://github.com/mmcloughlin/x/tree/master/profile

I started from scratch but matched the pkg/profile API (nearly completely), but this also supports running multiple profiles at once, and configuration with the idiomatic flags like go test.

Feedback appreciated.

from profile.

davecheney avatar davecheney commented on August 28, 2024

Hi, please don't take this the wrong way but I'm going to close this issue. It was my mistake for not closing the issue when I made this comment, #46 (comment). My position has not changed, I encourage you to use the source, luke.

from profile.

mmcloughlin avatar mmcloughlin commented on August 28, 2024

Yes you were very clear on that 😂

I should have clarified my intention. I was considering cleaning up my experimental code and creating github.com/mmcloughlin/profile. But I thought I'd seek feedback and gauge interest first, and people on this issue seem like a good audience.

from profile.

bygui86 avatar bygui86 commented on August 28, 2024

@mmcloughlin I did already a fork of this project

you can find it here https://github.com/bygui86/multi-profile

your feedback is more than welcome!

from profile.

mmcloughlin avatar mmcloughlin commented on August 28, 2024

@mmcloughlin I did already a fork of this project

you can find it here https://github.com/bygui86/multi-profile

your feedback is more than welcome!

Yes, I saw your project. Two reasons I prefer my approach (other than not-invented-here syndrome):

  • More closely matches existing pkg/profile API. In particular defer profile.Start(profile.CPUProfile, profile.MemProfile).Stop() would work rather than two defer lines.
  • Configuration by flags

from profile.

mmcloughlin avatar mmcloughlin commented on August 28, 2024

Published: https://github.com/mmcloughlin/profile

from profile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.