GithubHelp home page GithubHelp logo

Comments (10)

asmecher avatar asmecher commented on August 17, 2024 1

Do you think adding the ROR icon next to ROR-affiliated universities could help distinguish...

...yes! That's a great and obvious solution that I totally didn't think of. Thanks!

from pkp-lib.

asmecher avatar asmecher commented on August 17, 2024 1

Thanks, @salmanm2003!

@Vitaliy-1, can you review the PR above?

As for the ROR implementation for OJS 3.5, that should be coming from @GaziYucel, who is working on this from TIB in Germany. He should have details before too long.

from pkp-lib.

twakeford avatar twakeford commented on August 17, 2024

We're happy with it from our side.

The only comment from us is that the 'Same institution as author' function raised quite a lot of back and forth when implemented for the reviewer invitation function, as it is a match based on the affiliation string, which has room for missing valid matches due to the entry being slightly different (e.g. a typo in the affiliation). We still think that this is the most viable option though until ROR functionality is expanded, and the function already implemented for reviewer invitations has been very well received by our editors. Should the exact string match not be optimal then we suggest that a partial match or possible match is used, so that a flag is raised based on similarity rather than exact match. i.e. If the affiliation is 'University of Liverpool', 'Uni of Liverpool', or 'Liverpool University' then the table would still bring up a flag, but perhaps we alter the text presented on the screen so it isn't as definite as 'Same institution as author' in case of mismatches. Ultimately, it is just a flag to tell the editor to look into it prior to assignment.

from pkp-lib.

asmecher avatar asmecher commented on August 17, 2024

Thanks, @Devika008 and @twakeford! Yes, the "Same instution as author" feature was my only concern reviewing the design. We are integrating ROR into 3.5, so it'll be much more likely that authors will use it -- but we will still support plaintext affiliations too, and those will be hard to reliably match. I can think of two suggestions...

  • Warn "same institution" when there's a match on ROR, but don't try to match plaintext affilations. It'll be too unreliable (and possibly slow) and I'd rather we focused on encouraging ROR uptake
  • Maybe introduce a visual indication that the author (or editor) has a non-machine-readable affiliation? We could adopt this wherever affiliations are entered/used in order to encourage ROR adoption (and warn when it's not been taken up) without outright preventing folks from continuing without RORs.

from pkp-lib.

Devika008 avatar Devika008 commented on August 17, 2024

Maybe introduce a visual indication that the author (or editor) has a non-machine-readable affiliation?

@asmecher Do you think adding the ROR icon next to ROR-affiliated universities could help distinguish between those with machine-readable affiliations and those without? I believe this would eliminate the need for another icon and reduce the user's learning curve.

I fully support displaying the "same institution as author" tag only for machine-readable institutions. Otherwise, we'd need a complex mechanism to sort through similar affiliations, which isn't necessary. While this approach relies on some human judgment, it's better than presenting incomplete information.

from pkp-lib.

Devika008 avatar Devika008 commented on August 17, 2024

So what would the next steps be on this?

from pkp-lib.

asmecher avatar asmecher commented on August 17, 2024

@twakeford, do you have enough information to proceed as discussed above?

from pkp-lib.

jardakotesovec avatar jardakotesovec commented on August 17, 2024

Hi looking great,
couple of questions

  1. Where the Interests would be taken from?
  2. Are we ok to basically rebuild this in vue.js? Which also means creating API for assigning participant and possibly endpoint for searching the participants (not sure how much is already covered with existing user endpoint)?

I am always for finding excuses to reduce technical debt and expand our rest API. But it will be bit more work compared to just sneaking in these new information into legacy stack.

Thanks!
Jarda

from pkp-lib.

twakeford avatar twakeford commented on August 17, 2024

I'm happy to go with:

  • Warn "same institution" when there's a match on ROR, but don't try to match plaintext affilations. It'll be too unreliable (and possibly slow) and I'd rather we focused on encouraging ROR uptake

I agree that it is better to encourage ROR uptake than find a hacky way of doing it.

For

  • Where the Interests would be taken from?

I assumed that they would be pulled from the editors user profile at the time in the same way that the affiliation will be.

from pkp-lib.

salmanm2003 avatar salmanm2003 commented on August 17, 2024

Hi @asmecher,
I've just submitted PR #10312, which implements the details from the above screenshot/conversation. However, I couldn't find a compatible ROR version for OJS 3.5 to match the affiliation. Please let me know when the plugin is ready so I can complete that step as well.

from pkp-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.