GithubHelp home page GithubHelp logo

Git file with space raise exception about pls HOT 5 CLOSED

pls-rs avatar pls-rs commented on July 19, 2024
Git file with space raise exception

from pls.

Comments (5)

dhruvkb avatar dhruvkb commented on July 19, 2024 1

Since Git v2.17.1 is quite old (2018), I won't be able to add support for it. But since it hasn't reached EOL, if you want to submit a pull request, I'll be happy to review and merge it.

from pls.

dhruvkb avatar dhruvkb commented on July 19, 2024 1

Thank you @PTank for finding and fixing the issue! It's been released in v5.4.0.

from pls.

dhruvkb avatar dhruvkb commented on July 19, 2024

I was not able to reproduce this on my macOS dev machine.

  • git status --porcelain wraps the output file name in quotes if it contains spaces.
  • shlex.split automatically considers quoted strings as one block, thus returning only 2 components in the list.
  • pls can handle these cases.

Screenshot 2022-08-08 at 6 58 51 PM

from pls.

PTank avatar PTank commented on July 19, 2024

Ok, i'm on linux/ Ubuntu
git: 2.17.1

The output do not quote the filename.

$> touch "test.lol lol"
$> git status  --porcelain
?? test.lol lol

from pls.

PTank avatar PTank commented on July 19, 2024

Work well with git: 2.37.1.

But sadly cannot use pls at work, can't add git ppa here.

Thanks

from pls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.