1.7.10 print prugin and pre_tag_label_filter failure about pmacct

[paololucente]

Hi @danyrlz ,

Thanks for reporting this!

Can you please remove one moment the pre_tag_label_filter to observe what happens? Is all traffic labelled as other? Or what happens? It may also help if you could send me a sample of a sFlow packet, especially to test the direction part of matching / non-matching.

Paolo

[danyrlz]

Hello,
it looks like there is more fundamental issue as we get the same without the "direction" key:

.....
pre_tag_label_filter[bgp2]: ing
.....
set_label=ing    ip=0.0.0.0/0   label=ing    jeq=src
#
# START_SRC-Static
set_tag=xxxx ip=0.0.0.0/0 src_mac=xx:xx:xx:xx:xx:xx label=src jeq=dst
# START_DST-Static
set_tag2=xxxx ip=0.0.0.0/0 dst_mac=yy:yy:yy:yy:yy:yy label=dst

RESULT:

2023-12-14T07:25:01Z INFO ( bgp2/print ): *** Purging cache - START (PID: 82609) ***
2023-12-14T07:25:01Z INFO ( bgp2/print ): *** Purging cache - END (PID: 82609, QN: 0/0, ET: X) ***

Here is with disabled filter:

.....
pre_tag_label_filter[mac2]: -null
#pre_tag_label_filter[bgp2]: ing
.....
set_label=ing    ip=0.0.0.0/0   label=ing    jeq=src
#
# START_SRC-Static
set_tag=xxxx ip=0.0.0.0/0 src_mac=xx:xx:xx:xx:xx:xx label=src jeq=dst
# START_DST-Static
set_tag2=xxxx ip=0.0.0.0/0 dst_mac=yy:yy:yy:yy:yy:yy label=dst

RESULT:

2023-12-14T07:30:01Z INFO ( mac2/print ): *** Purging cache - START (PID: 82721) ***
2023-12-14T07:30:01Z INFO ( bgp2/print ): *** Purging cache - START (PID: 82722) ***
2023-12-14T07:30:01Z INFO ( mac2/print ): *** Purging cache - END (PID: 82721, QN: 6779/6779, ET: 0) ***
2023-12-14T07:30:03Z INFO ( bgp2/print ): *** Purging cache - END (PID: 82722, QN: 634790/634790, ET: 2) ***

[paololucente]

Hi Jordan ( @danyrlz ),

I should have been able to reproduce the issue and fix it. Can you give a try to latest code and confirm whether it works for you?

Paolo

[danyrlz]

Hello again,

It seems to work now but we get another error with the same config from 1.7.8:

2023-12-15T11:30:46Z INFO ( default/core ): [/etc/pmacct/pretag/peer5b.map] (re)loading map.
2023-12-15T11:30:46Z INFO ( bgp2/print ): cache entries=5000000 base cache memory=17160000000 bytes
2023-12-15T11:30:46Z INFO ( default/core ): [/etc/pmacct/pretag/peer5b.map] map successfully (re)loaded.
2023-12-15T11:30:46Z INFO ( default/core ): [/etc/pmacct/pretag/peer5b.map] (re)loading map.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.
2023-12-15T11:30:46Z WARN ( default/core ): [/etc/pmacct/pretag/peer5b.map] Unresolved label 'dst'. Ignoring it.

We use the same pretag map structure like above. When we use just few lines in the new version it looks ok but when we load the full map(around 500 lines) we get the error.
Is there any limitation or anything new specific here?

[danyrlz]

Hello Paolo @paololucente,

It looks like when we have more than 52 lines with "jeq=dst" statement the problem above is present.

[paololucente]

Hi Jordan @danyrlz , sorry the silence, i was working on some code -- having been able to reproduce your issue. I have some code ready & testing at the moment. I should have news by the end of the day. Paolo

[paololucente]

Hi Jordan @danyrlz , the last commit ( 547e241 ) should address your remaining issue -- can you give it a try and let me know if all looks to work as expected?

Paolo