how to compile with clang ? about libpmemobj-cpp

[szyrom]

Hi,
thanks for this catch. clang 3.6 does not fully support all C++11 features (traits in this case).
It should work with this PR #325 (will be merged after code review).

[igchor]

@freboat I strongly recommend to upgrade your compiler, this should fix the issue. However, if you want to use clang 3.6 you can wait until #325 is merged or apply the following patch :

---
 include/libpmemobj++/detail/common.hpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/libpmemobj++/detail/common.hpp b/include/libpmemobj++/detail/common.hpp
index d570464..aba2063 100644
--- a/include/libpmemobj++/detail/common.hpp
+++ b/include/libpmemobj++/detail/common.hpp
@@ -95,7 +95,15 @@
  * and 0 in gcc. It means that for gcc < 5 IS_TRIVIALLY_COPYABLE is more
  * restrictive than is_trivially_copyable.
  */
+#if !defined(LIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY)
 #if !defined(__clang__) && defined(__GNUG__) && __GNUC__ < 5
+#define LIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY 1
+#else
+#define LIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY 0
+#endif
+#endif
+
+#if LIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY
 #define IS_TRIVIALLY_COPYABLE(T) __has_trivial_copy(T)
 #else
 #define IS_TRIVIALLY_COPYABLE(T) std::is_trivially_copyable<T>::value
-- 

After that, to compile libpmemobj-cpp tests and examples with your clang version please run cmake with: -DCMAKE_CXX_FLAGS=-DLIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY=1. If you want to compile your application with libmemobj-cpp using clang 3.6 you must set LIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY=1 in your code or during compilation.

[freboat]

@szyrom & @igchor thanks for your kind reply,
i updated clang to 3.9 run cmake with -DCMAKE_CXX_FLAGS=-DLIBPMEMOBJ_CPP_USE_HAS_TRIVIAL_COPY=1
but got another error:

In file included from /home/brook/pmem/libpmemobj-cpp/tests/string_exceptions/string_exceptions.cpp:35:
/home/brook/pmem/libpmemobj-cpp/include/libpmemobj++/experimental/slice.hpp:79:15: error: no member named 'out_of_range' in namespace
'std'
throw std::out_of_range("pmem::obj::slice");
~~~~~^
/home/brook/pmem/libpmemobj-cpp/include/libpmemobj++/experimental/slice.hpp:137:15: error: no member named 'out_of_range' in namespace
'std'
throw std::out_of_range("pmem::obj::slice");
~~~~~^

[freboat]

@ALL, i have fixed the error,
include/libpmemobj++/experimental/slice.hpp lost the stdexcept headfile, just add and it works:

#include <stdexcept>

[szyrom]

@freboat Will you submit pull request? Your contribution is more than welcome :)