Comments (7)
Hey! Thanks for the issue.
I just shipped v0.1.0
(on npm) - I tested with the latest master and I wasn't able to reproduce what you're mentioning. Can you try it out and see if it works?
from react-refresh-webpack-plugin.
I tried again with the latest released version and on master (nice overlay!), but do still see things error out when I add/remove hooks. Sorry for not adding a simple test, but simply adding/remove the following from a React.FC
triggers the error overlay:
const callback = React.useCallback(() => {}, []);
It's not a big deal at this point (just an extra reload I can trigger by making more edits). I was mainly curious about whether this is the expected normal behavior.
Thanks!
from react-refresh-webpack-plugin.
I tried again with the latest released version and on master (nice overlay!), but do still see things error out when I add/remove hooks. Sorry for not adding a simple test, but simply adding/remove the following from a
React.FC
triggers the error overlay:
const callback = React.useCallback(() => {}, []);
It's not a big deal at this point (just an extra reload I can trigger by making more edits). I was mainly curious about whether this is the expected normal behavior.
Thanks!
I'll have to check if I did something wrong. I am pretty sure state/reducer/refs work, let me check.
from react-refresh-webpack-plugin.
I was mainly curious about whether this is the expected normal behavior.
No
from react-refresh-webpack-plugin.
I tried again with the latest released version and on master (nice overlay!), but do still see things error out when I add/remove hooks. Sorry for not adding a simple test, but simply adding/remove the following from a
React.FC
triggers the error overlay:
const callback = React.useCallback(() => {}, []);
It's not a big deal at this point (just an extra reload I can trigger by making more edits). I was mainly curious about whether this is the expected normal behavior.
Thanks!
I couldn't reproduce this in a normal webpack app. I guess it might have something to do with integration between this and CRA. #7
from react-refresh-webpack-plugin.
As mentioned in #25, I can resolve this in my CRA app by setting webpackConfig.optimization.runtimeChunk = false;
via craco. Now everything seems to be working like a charm!
from react-refresh-webpack-plugin.
Fixed in v0.1.3
🎉
from react-refresh-webpack-plugin.
Related Issues (20)
- Cannot read properties of undefined (reading 'call') at at options.factory HOT 1
- Relative imports outside of src/ are not supported. HOT 6
- Can I use a custom domain and SSL cert for the cable URL? HOT 1
- Tsc error when upgraded to 0.5.X from 0.4.X HOT 1
- Is that possible to refresh when files in node_modules are changed?
- Rewrite window.fetch method It will not work!
- Using with webpack-hot-middleware, issues
- npm ERR! ERESOLVE could not resolve HOT 1
- Security vulnerability - loader-utils 2.0.4 HOT 2
- Getting lot's of *.hot-update.js files in dist folder HOT 1
- Not working with multiple entry points in webpack where one entry does not use react
- Expand webpack-dev-server dev dependency to include the newes semver 5.x HOT 1
- erroroverlay
- There are some edge cases where we have to manually refresh the page to see the change. HOT 1
- Issues when combining webpack HMR and react-refresh-webpack-plugin HOT 10
- `useEffect` inside refreshed code runs needlessly HOT 1
- Alternative for React Class Components. HOT 1
- Issues with peer dependencies found HOT 1
- Memory cleanup doesn't happen on incremental compiles HOT 3
- Using the external configuration item of webpack in the development environment can cause react refresh to fail HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-refresh-webpack-plugin.