GithubHelp home page GithubHelp logo

Comments (8)

giulioz avatar giulioz commented on July 21, 2024 1

....and I confirm that fixing the lockfile to force the 8.0.0 versions fixes the bug.

Sorry for the investigation comments spam

from gltfjsx.

andrescrd avatar andrescrd commented on July 21, 2024 1

It has not worked for me with a clone of the project.
I removed the last parentheses of line 2 of the file "gltfjsx.js" and it started working

change this
require ('jsdom-global') ()

for this
require ('jsdom-global')

from gltfjsx.

giulioz avatar giulioz commented on July 21, 2024
/private/tmp/gltfbug/node_modules/whatwg-url/dist/URL.js:84
  if (!globalNames.some(globalName => exposed.has(globalName))) {
                   ^

TypeError: Cannot read property 'some' of undefined
    at Object.exports.install (/private/tmp/gltfbug/node_modules/whatwg-url/dist/URL.js:84:20)
    at exports.installInterfaces (/private/tmp/gltfbug/node_modules/jsdom/lib/jsdom/living/interfaces.js:202:24)
    at setupWindow (/private/tmp/gltfbug/node_modules/jsdom/lib/jsdom/browser/Window.js:63:3)
    at new Window (/private/tmp/gltfbug/node_modules/jsdom/lib/jsdom/browser/Window.js:107:3)
    at exports.createWindow (/private/tmp/gltfbug/node_modules/jsdom/lib/jsdom/browser/Window.js:38:10)
    at new JSDOM (/private/tmp/gltfbug/node_modules/jsdom/lib/api.js:36:20)
    at globalJsdom (/private/tmp/gltfbug/node_modules/jsdom-global/index.js:29:18)
    at Object.<anonymous> (/private/tmp/gltfbug/node_modules/gltfjsx/gltfjsx.js:2:24)
    at Module._compile (internal/modules/cjs/loader.js:1151:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1171:10)

from gltfjsx.

giulioz avatar giulioz commented on July 21, 2024

This does not occur when running the app from a clone, only with npx or with yarn run

from gltfjsx.

giulioz avatar giulioz commented on July 21, 2024

image

Investigating the lockfiles we can find that this package versions are different between the repo and the installed version.

from gltfjsx.

giulioz avatar giulioz commented on July 21, 2024

It has not worked for me with a clone of the project.

I removed the last parentheses of line 2 of the file "gltfjsx.js" and it started working

change this

require ('jsdom-global') ()

for this

require ('jsdom-global')

Actually, you're supposed to call the require as function to load the jsdom environment

Anyway, did you install deps using yarn?

from gltfjsx.

andrescrd avatar andrescrd commented on July 21, 2024

I was using npm. I switched to yarn and it works perfectly. Thank you :D

from gltfjsx.

gsimone avatar gsimone commented on July 21, 2024

This is now fixed in version 2.0.5 for people using npx to run the command 👍

from gltfjsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.