GithubHelp home page GithubHelp logo

Comments (5)

asyniakov avatar asyniakov commented on September 16, 2024 1

fixed. confirmed

from pymcubes.

pmneila avatar pmneila commented on September 16, 2024

Hi @asyniakov,

Just in case, could you give me a minimal piece of code that reproduces the problem?

Also, what are the duplicate vertices in your image? The yellow dots? Did you explicitly find and draw the duplicate vertices?

from pymcubes.

asyniakov avatar asyniakov commented on September 16, 2024

Hello @pmneila,

Sure! Here is a minimal piece of code that reproduces the problem:

The sphere is located in C = {4,4,4} with diameter 8. bbox is {2,2,2} and {8,8,8}

auto sdf = [](auto p){
    return length(p - { 4,4,4 }) - 4;
};

mc::marching_cubes({2, 2, 2}, { 9, 9, 9 }, 20, 20, 20, sdf, 0, vertices, polygons);

Please ignore my previous image, here is the better visualization of the problem;
image
red vertices - are duplicate vertices (which I believe is incorrect), yellow ones are boundary vertices (they are OK).

The main question - how did I find duplicate vertices (red ones)?
I passed vertices and polygons to OpenMesh library (that uses halfedge data structure inside for the topology) and then simply highlighted all boundary vertices. As a result, I got the image as in my previous post. I expected to see yellow dots only on boundaries. I double-checked array before passing to OpenMesh and there are duplicates indeed.

This problem is repro on any sdfs that are "clipped" by lower value (like 2,2,2 in this example)

Please let me know what else I can help with.

from pymcubes.

pmneila avatar pmneila commented on September 16, 2024

Hi @asyniakov

It took longer than expected, but it is finally fixed. You can install the last version with

$ pip install PyMCubes --upgrade

or downloading and compiling the code from GitHub.

Thank you for letting me know!

from pymcubes.

asyniakov avatar asyniakov commented on September 16, 2024

@pmneila thank you! I'll try check it next week and let you know if find some other issues.

from pymcubes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.