GithubHelp home page GithubHelp logo

Comments (7)

FezVrasta avatar FezVrasta commented on May 28, 2024 1

So, the maintainer of semantic-release seems to hate you unconditionally because you created something extremely useful without his permission...

So he's actively working against your project to make sure the whole semantic-release ecosystem doesn't work properly with semantic-release-monorepo.

He rejected my PR, but I published my fork as semantic-release-monorepo-npm for anyone that may need it.

from semantic-release-monorepo.

pmowrer avatar pmowrer commented on May 28, 2024

I haven't worked with custom npm registries at all. I think semantic-release supports them. My intuition would be that if you can configure it for semantic-release, it should just work. If it doesn't, please provide some information about what is going wrong.

from semantic-release-monorepo.

FezVrasta avatar FezVrasta commented on May 28, 2024

The problem I see is that the npm plugin reads the registry configuration from package.json, so in our case it's going to read the package.json of each of the packages.

This means that I have to specify on each package's package.json the registry configuration.

from semantic-release-monorepo.

FezVrasta avatar FezVrasta commented on May 28, 2024

I think this PR I prepared may solve this problem.

semantic-release/npm#62

I'm not sure how responsive are the guys of semantic-release, I hope to see it merged.

from semantic-release-monorepo.

pmowrer avatar pmowrer commented on May 28, 2024

I was going to suggest opening a PR to make the registry an option on the npm plugin config. Otherwise, I can't think of a way of configuring this across a monorepo without doing it in each individual package.json.

On the other hand, I don't think I mind the idea of having the registry definition in each package.json. It's explicit and clear. I think each package.json should contain enough information to be able to be managed individually, not relying on a global definition to complete its metadata. It also avoids the ambiguity that would be introduced if a monorepo contained packages belonging to multiple registries (though maybe that's an insane use-case).

from semantic-release-monorepo.

pmowrer avatar pmowrer commented on May 28, 2024

Thanks for the update! FWIW, I think I do agree with him regarding this particular change (my reasoning above), but he could certainly greatly improve how he communicates.

from semantic-release-monorepo.

tcandens avatar tcandens commented on May 28, 2024

Just for anyone looking...

I ended up solving this problem by specifying the registry in .npmrc at the root of the directory and then expanding the release script.

{
  "scripts: {
    "release": "lerna exec --no-bail --concurrency 1 -- 'cp ../../.npmrc ./; npx --no-install semantic-release -e semantic-release-monorepo; rm .npmrc"
  }
}

from semantic-release-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.